Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio service ducking #42

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

emphasize
Copy link
Member

@emphasize emphasize commented Nov 8, 2023

Audio service ducking:

  • Pauses (... and unpauses) the audio service for the duration the TTS queue is processed or a sound is instantly played.
  • if the TTS config key pulse_duck is True, pulse takes precedence to handle this mechanic.

Live tested with pulse_duck on/off

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev@1181bcd). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev     #42   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?       8           
  Lines          ?     958           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?     958           
  Partials       ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl added the enhancement New feature or request label Nov 8, 2023
@JarbasAl JarbasAl merged commit 0a3b034 into OpenVoiceOS:dev Nov 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants