refactor/drop audio service #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarbasAl
added
breaking
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #49 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 8
Lines ? 951
Branches ? 0
=====================================
Hits ? 0
Misses ? 951
Partials ? 0 ☔ View full report in Codecov by Sentry. |
puts it behind a config option, replaces
NeonJarbas
force-pushed
the
refactor/ovos_media
branch
from
27bbed2
to
23844a6
Compare
puts it behind a config option, replaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migration to ovos-media as companion service
allows disabling the native audio service via config, and logs a warning about doing it
new config option, once ovos-media is widely adopted should be changed to false in ovos-config mycroft.conf