fix/ducking #67
Merged
fix/ducking #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restore/lower_volume could be called multiple times, getting audio plugins off track eg, by calling lower_volume twice it can cause vlc plugin to loose track of normal volume https://github.com/OpenVoiceOS/ovos-plugin-vlc/blob/dev/ovos_plugin_vlc/__init__.py#L106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self.volume_is_low variable was ignored
restore/lower_volume could be called multiple times, getting audio plugins off track
eg, by calling lower_volume twice it can cause vlc plugin to loose track of normal volume https://github.com/OpenVoiceOS/ovos-plugin-vlc/blob/dev/ovos_plugin_vlc/__init__.py#L106