Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/pairing_checks_for_offline #29

Merged
merged 9 commits into from
Feb 15, 2023
Merged

fix/pairing_checks_for_offline #29

merged 9 commits into from
Feb 15, 2023

Conversation

JarbasAl
Copy link
Member

No description provided.

@JarbasAl JarbasAl added the bug Something isn't working label Feb 10, 2023
@JarbasAl JarbasAl mentioned this pull request Feb 10, 2023
93 tasks
@JarbasAl JarbasAl marked this pull request as draft February 10, 2023 18:45
@JarbasAl JarbasAl marked this pull request as ready for review February 15, 2023 17:08
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (dev@c1df4f8). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             dev     #29   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      16           
  Lines          ?    1740           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?    1740           
  Partials       ?       0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@NeonDaniel NeonDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and tests are passing. I think this addresses a bug @ChanceNCounter ran into, so we should probably wait for his review.

@JarbasAl JarbasAl merged commit a9a9c98 into dev Feb 15, 2023
@JarbasAl JarbasAl deleted the fix/pairing_checks branch February 15, 2023 17:40
@github-actions github-actions bot mentioned this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants