Skip to content
This repository has been archived by the owner on Nov 20, 2024. It is now read-only.

Fix path errors in Database init #58

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

NeonDaniel
Copy link
Member

@NeonDaniel NeonDaniel commented Jan 4, 2024

Breaking change found in OpenVoiceOS/ovos-PHAL-plugin-oauth#15
Change comes from #30
Includes test coverage for updated classes

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev@a236ef1). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev     #58   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      14           
  Lines          ?    2587           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?    2587           
  Partials       ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NeonDaniel NeonDaniel changed the title Fix path error in OAuthApplicationDatabase init Fix path errors in Database init Jan 4, 2024
@NeonDaniel NeonDaniel requested a review from a team January 4, 2024 01:07
@NeonDaniel NeonDaniel marked this pull request as ready for review January 4, 2024 01:07
@JarbasAl JarbasAl added the bug Something isn't working label Jan 4, 2024
@JarbasAl JarbasAl merged commit 6ab70da into dev Jan 4, 2024
7 checks passed
@JarbasAl JarbasAl deleted the FIX_OauthApplicationDatabaseDirectory branch January 4, 2024 01:17
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants