Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove oauth refresh endpoint #61

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

forslund
Copy link
Contributor

@forslund forslund commented Jan 16, 2024

Remove refresh_endpoint as suggested in #59.

Since the change is breaking major version should have been updated but since it's pre 1.0.0 minor was updated in it's place

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev@c10cc52). Learn more about missing BASE report.

Current head 8912ae3 differs from pull request most recent head 9e6cf02

Please upload reports for the commit 9e6cf02 to get more accurate results.

Files Patch % Lines
ovos_backend_client/version.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev     #61   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      14           
  Lines          ?    2587           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?    2587           
  Partials       ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl added bug Something isn't working refactor breaking labels Jan 16, 2024
@JarbasAl
Copy link
Member

just realized most things in the wild are pinning 0.1.X , this change means those will be stuck with the recursion bug

can we break this into 2 PRs so those older versions can still get the bugfix, and then the removal of the endpoint marks the 0.2.0 breaking release ?

@forslund
Copy link
Contributor Author

just realized most things in the wild are pinning 0.1.X , this change means those will be stuck with the recursion bug

can we break this into 2 PRs so those older versions can still get the bugfix, and then the removal of the endpoint marks the 0.2.0 breaking release ?

Sure thing. I'll break them apart

@forslund forslund marked this pull request as draft January 16, 2024 19:35
@forslund forslund force-pushed the remove-oauth-refresh branch 3 times, most recently from bb7c9c2 to 8912ae3 Compare January 16, 2024 19:36
The oauth_standard doesn't include a separate refresh endpoint, refresh
should use the token endpoint.
Breaking changes have occured and the version is updated accordingly
@forslund forslund marked this pull request as ready for review June 13, 2024 18:04
@forslund
Copy link
Contributor Author

Since there's been some movement around this I've taken the time to rebase so it's merging cleanly again.

@forslund
Copy link
Contributor Author

Is this still of interest or should I close the PR?

@forslund forslund changed the title Remove oauth refresh Remove oauth refresh endpoint Aug 8, 2024
@forslund
Copy link
Contributor Author

^ ping @NeonDaniel @JarbasAl.

Copy link

coderabbitai bot commented Sep 10, 2024

Warning

Rate limit exceeded

@JarbasAl has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 24 minutes and 40 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 4ee827c and 719a8d4.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@JarbasAl JarbasAl merged commit 09dbcb0 into OpenVoiceOS:dev Sep 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking bug Something isn't working refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants