-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove oauth refresh endpoint #61
Conversation
2faa5e9
to
99ad91f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #61 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 14
Lines ? 2587
Branches ? 0
=====================================
Hits ? 0
Misses ? 2587
Partials ? 0 ☔ View full report in Codecov by Sentry. |
just realized most things in the wild are pinning 0.1.X , this change means those will be stuck with the recursion bug can we break this into 2 PRs so those older versions can still get the bugfix, and then the removal of the endpoint marks the 0.2.0 breaking release ? |
Sure thing. I'll break them apart |
bb7c9c2
to
8912ae3
Compare
The oauth_standard doesn't include a separate refresh endpoint, refresh should use the token endpoint.
Breaking changes have occured and the version is updated accordingly
8912ae3
to
9e6cf02
Compare
Since there's been some movement around this I've taken the time to rebase so it's merging cleanly again. |
Is this still of interest or should I close the PR? |
^ ping @NeonDaniel @JarbasAl. |
Warning Rate limit exceeded@JarbasAl has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 24 minutes and 40 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Remove refresh_endpoint as suggested in #59.
Since the change is breaking major version should have been updated but since it's pre 1.0.0 minor was updated in it's place