fix/huge_integer_error #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timeout is getting multiplied by 60 every time it is serialized/deserialized, conversion from seconds to minutes should only be done when assigning the default value from config
```
exception calling callback for <Future at 0x7f3c5ff8d0 state=finished raised ValueError>
Traceback (most recent call last):
File "/usr/lib/python3.11/concurrent/futures/_base.py", line 340, in _invoke_callbacks
callback(self)
File "/home/ovos/.venv/lib/python3.11/site-packages/pyee/_executor.py", line 57, in _callback
self.emit("error", exc)
File "/home/ovos/.venv/lib/python3.11/site-packages/pyee/_base.py", line 118, in emit
self._emit_handle_potential_error(event, args[0] if args else None)
File "/home/ovos/.venv/lib/python3.11/site-packages/pyee/_base.py", line 88, in _emit_handle_potential_error
raise error
File "/usr/lib/python3.11/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_bus_client/client/client.py", line 162, in on_default_session_update
SessionManager.update(sess, make_default=True)
File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_bus_client/session.py", line 538, in update
LOG.debug(f"replacing default session with: {sess.serialize()}")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: Exceeds the limit (4300 digits) for integer string conversion; use sys.set_int_max_str_digits() to increase the limit
```
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #58 +/- ##
==========================================
- Coverage 53.58% 52.92% -0.67%
==========================================
Files 14 14
Lines 1073 1111 +38
==========================================
+ Hits 575 588 +13
- Misses 498 523 +25
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timeout is getting multiplied by 60 every time it is serialized/deserialized, conversion from seconds to minutes should only be done when assigning the default value from config