Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated #61

Merged
merged 1 commit into from
Oct 24, 2023
Merged

remove deprecated #61

merged 1 commit into from
Oct 24, 2023

Conversation

JarbasAl
Copy link
Member

remove deprecated kwargs that were only present during the alpha release cycle while Session was being introduced

these need removing before the first stable released including Session

remove deprecated kwargs that were only present during the alpha release cycle while Session was being introduced

these need removing before the first stable released including Session
@JarbasAl JarbasAl added the packaging dependency updates or packaging changes label Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d00dd55) 52.92% compared to head (9e8eaee) 52.76%.
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #61      +/-   ##
==========================================
- Coverage   52.92%   52.76%   -0.17%     
==========================================
  Files          14       14              
  Lines        1111     1105       -6     
==========================================
- Hits          588      583       -5     
+ Misses        523      522       -1     
Files Coverage Δ
ovos_bus_client/session.py 54.54% <ø> (-0.70%) ⬇️
ovos_bus_client/version.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit 678eed7 into dev Oct 24, 2023
6 of 7 checks passed
This was referenced Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging dependency updates or packaging changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants