Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor/orjson #75

Merged
merged 3 commits into from
Jan 13, 2024
Merged

refactor/orjson #75

merged 3 commits into from
Jan 13, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Jan 8, 2024

move all message serialization and deserialization to orjson

this brings extra performance

https://github.com/ijl/orjson

@JarbasAl
refactor/orjson
a951239 
move all message serialization and deserialization to orjson

this brings extra performance
@JarbasAl JarbasAl marked this pull request as draft January 8, 2024 04:15
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2024 •
edited
Loading

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (863e711) 39.68% compared to head (8cf46f9) 34.78%.
Report is 17 commits behind head on dev.

Files Patch % Lines
ovos_bus_client/message.py 57.14% 3 Missing ⚠️
ovos_bus_client/util/__init__.py 25.00% 3 Missing ⚠️
ovos_bus_client/client/client.py 33.33% 2 Missing ⚠️
ovos_bus_client/version.py 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev      #75      +/-   ##
==========================================
- Coverage   39.68%   34.78%   -4.90%     
==========================================
  Files          17       17              
  Lines        1726     1969     +243     
==========================================
  Hits          685      685              
- Misses       1041     1284     +243

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl marked this pull request as ready for review January 8, 2024 04:22
j1nx
j1nx approved these changes Jan 13, 2024
View reviewed changes
Copy link
Member

@j1nx j1nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this within the ovos-core container and LGTM.

Below the bootlog of teh container with this new bus-client installed and used.

Jan 13 12:22:44 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:44.256 - OVOS - mycroft:<module>:37 - WARNING - mycroft has been deprecated! please start importing from ovos_core and companion packages
Jan 13 12:22:44 OpenVoiceOS-840dca ovos-core[9967]: mycroft module remains available for backwards compatibility and will be removed in version 0.2.0
Jan 13 12:22:44 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:44.435 - skills - ovos_plugin_manager.language:create:233 - INFO - Loaded the Language Translation plugin ovos-translate-plugin-server
Jan 13 12:22:44 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:44.495 - skills - ovos_core.transformers:load_plugins:29 - INFO - loaded utterance transformer plugin: ovos-utterance-normalizer
Jan 13 12:22:44 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:44.542 - skills - ovos_bus_client.util.scheduler:run:145 - INFO - EventScheduler Started
Jan 13 12:22:44 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:44.545 - skills - ovos_core.skill_manager:on_started:61 - INFO - Skills Manager is starting up.
Jan 13 12:22:44 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:44.579 - skills - ovos_core.skill_manager:on_alive:65 - INFO - Skills Manager is alive.
Jan 13 12:22:44 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:44.580 - skills - ovos_core.skill_manager:_load_on_startup:532 - INFO - Loading offline skills...
Jan 13 12:22:48 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:48.117 - skills - ovos_core.skill_manager:run:411 - WARNING - `wait_for_internet` is a deprecated option, update to specify `network_skills`or `internet_skills` in `re>
Jan 13 12:22:54 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:54.617 - skills - ovos_core.skill_manager:_load_on_internet:486 - INFO - Loading skills that require internet (and network)...
Jan 13 12:22:55 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:55.622 - skills - ovos_core.intent_services.padatious_service:train:145 - INFO - Training complete.
Jan 13 12:22:56 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:56.122 - skills - ovos_core.skill_manager:on_ready:69 - INFO - Skills Manager is ready.
Jan 13 12:22:56 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:56.124 - skills - ovos_core.skill_manager:run:456 - INFO - Skills loaded, waiting for GUI to load more!
Jan 13 12:22:57 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:57.650 - skills - ovos_workshop.skill_launcher:load:525 - INFO - ATTEMPTING TO LOAD PLUGIN SKILL: skill-ovos-homescreen.openvoiceos
Jan 13 12:22:57 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:57.860 - skill-ovos-homescreen.openvoiceos - INFO - Registering resting screen <bound method OVOSHomescreenSkill.handle_idle of <skill_ovos_homescreen.OVOSHomescreenSk>
Jan 13 12:22:57 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:57.867 - skill-ovos-homescreen.openvoiceos - INFO - Registering resting screen
Jan 13 12:22:58 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:58.033 - skills - ovos_workshop.skill_launcher:_communicate_load_status:503 - INFO - Skill skill-ovos-homescreen.openvoiceos loaded successfully
Jan 13 12:22:58 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:58.036 - skills - ovos_workshop.skill_launcher:load:525 - INFO - ATTEMPTING TO LOAD PLUGIN SKILL: skill-ovos-fallback-chatgpt.openvoiceos
Jan 13 12:22:58 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:58.164 - skills - ovos_plugin_manager.language:create:233 - INFO - Loaded the Language Translation plugin ovos-translate-plugin-server
Jan 13 12:22:58 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:58.179 - skills - ovos_workshop.skills.fallback:register_fallback:420 - INFO - registering fallback handler -> ovos.skills.fallback.skill-ovos-fallback-chatgpt.openvoi>
Jan 13 12:22:58 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:58.190 - skills - ovos_workshop.skill_launcher:_communicate_load_status:503 - INFO - Skill skill-ovos-fallback-chatgpt.openvoiceos loaded successfully
Jan 13 12:22:58 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:58.193 - skills - ovos_workshop.skill_launcher:load:525 - INFO - ATTEMPTING TO LOAD PLUGIN SKILL: skill-ovos-youtube-music.openvoiceos
Jan 13 12:22:58 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:58.360 - skills - ovos_workshop.skill_launcher:_communicate_load_status:503 - INFO - Skill skill-ovos-youtube-music.openvoiceos loaded successfully
Jan 13 12:22:58 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:58.363 - skills - ovos_workshop.skill_launcher:load:525 - INFO - ATTEMPTING TO LOAD PLUGIN SKILL: skill-ovos-date-time.openvoiceos
Jan 13 12:22:58 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:58.625 - skills - ovos_core.skill_manager:handle_check_device_readiness:222 - INFO - Mycroft is all loaded and ready to roll!
Jan 13 12:22:59 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:59.698 - skills - ovos_workshop.skill_launcher:_communicate_load_status:503 - INFO - Skill skill-ovos-date-time.openvoiceos loaded successfully
Jan 13 12:22:59 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:59.701 - skills - ovos_workshop.skill_launcher:load:525 - INFO - ATTEMPTING TO LOAD PLUGIN SKILL: ovos-skill-personal.OpenVoiceOS
Jan 13 12:22:59 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:59.887 - skills - ovos_workshop.skill_launcher:_communicate_load_status:503 - INFO - Skill ovos-skill-personal.OpenVoiceOS loaded successfully
Jan 13 12:22:59 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:22:59.890 - skills - ovos_workshop.skill_launcher:load:525 - INFO - ATTEMPTING TO LOAD PLUGIN SKILL: skill-ovos-volume.openvoiceos
Jan 13 12:23:00 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:00.459 - skills - ovos_workshop.skill_launcher:_communicate_load_status:503 - INFO - Skill skill-ovos-volume.openvoiceos loaded successfully
Jan 13 12:23:00 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:00.462 - skills - ovos_workshop.skill_launcher:load:525 - INFO - ATTEMPTING TO LOAD PLUGIN SKILL: skill-ovos-naptime.openvoiceos
Jan 13 12:23:00 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:00.606 - skills - ovos_workshop.skill_launcher:_communicate_load_status:503 - INFO - Skill skill-ovos-naptime.openvoiceos loaded successfully
Jan 13 12:23:00 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:00.609 - skills - ovos_workshop.skill_launcher:load:525 - INFO - ATTEMPTING TO LOAD PLUGIN SKILL: skill-ovos-wolfie.openvoiceos
Jan 13 12:23:00 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:00.852 - skills - ovos_plugin_manager.language:create:233 - INFO - Loaded the Language Translation plugin ovos-translate-plugin-server
Jan 13 12:23:00 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:00.864 - skills - ovos_workshop.skill_launcher:_communicate_load_status:503 - INFO - Skill skill-ovos-wolfie.openvoiceos loaded successfully
Jan 13 12:23:00 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:00.867 - skills - ovos_workshop.skill_launcher:load:525 - INFO - ATTEMPTING TO LOAD PLUGIN SKILL: ovos-skill-alerts.openvoiceos
Jan 13 12:23:09 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:09.127 - skills - ovos_workshop.skill_launcher:_communicate_load_status:503 - INFO - Skill ovos-skill-alerts.openvoiceos loaded successfully
Jan 13 12:23:09 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:09.130 - skills - ovos_workshop.skill_launcher:load:525 - INFO - ATTEMPTING TO LOAD PLUGIN SKILL: skill-ovos-stop.openvoiceos
Jan 13 12:23:09 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:09.281 - skills - ovos_workshop.skills.fallback:register_fallback:420 - INFO - registering fallback handler -> ovos.skills.fallback.skill-ovos-stop.openvoiceos
Jan 13 12:23:09 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:09.291 - skills - ovos_workshop.skill_launcher:_communicate_load_status:503 - INFO - Skill skill-ovos-stop.openvoiceos loaded successfully
Jan 13 12:23:09 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:09.294 - skills - ovos_workshop.skill_launcher:load:525 - INFO - ATTEMPTING TO LOAD PLUGIN SKILL: skill-ovos-weather.openvoiceos
Jan 13 12:23:12 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:12.733 - skills - ovos_workshop.skill_launcher:_communicate_load_status:503 - INFO - Skill skill-ovos-weather.openvoiceos loaded successfully
Jan 13 12:23:12 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:12.736 - skills - ovos_workshop.skill_launcher:load:525 - INFO - ATTEMPTING TO LOAD PLUGIN SKILL: skill-ovos-ddg.openvoiceos
Jan 13 12:23:12 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:12.981 - skills - ovos_plugin_manager.language:create:233 - INFO - Loaded the Language Translation plugin ovos-translate-plugin-server
Jan 13 12:23:13 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:13.023 - skills - ovos_workshop.skill_launcher:_communicate_load_status:503 - INFO - Skill skill-ovos-ddg.openvoiceos loaded successfully
Jan 13 12:23:13 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:13.026 - skills - ovos_workshop.skill_launcher:load:525 - INFO - ATTEMPTING TO LOAD PLUGIN SKILL: skill-ovos-tunein.openvoiceos
Jan 13 12:23:13 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:13.408 - skills - ovos_workshop.skill_launcher:_communicate_load_status:503 - INFO - Skill skill-ovos-tunein.openvoiceos loaded successfully
Jan 13 12:23:13 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:13.412 - skills - ovos_workshop.skill_launcher:load:525 - INFO - ATTEMPTING TO LOAD PLUGIN SKILL: skill-ovos-wikipedia.openvoiceos
Jan 13 12:23:13 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:13.693 - skills - ovos_plugin_manager.language:create:233 - INFO - Loaded the Language Translation plugin ovos-translate-plugin-server
Jan 13 12:23:13 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:13.704 - skills - ovos_workshop.skill_launcher:_communicate_load_status:503 - INFO - Skill skill-ovos-wikipedia.openvoiceos loaded successfully
Jan 13 12:23:13 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:13.707 - skills - ovos_workshop.skill_launcher:load:525 - INFO - ATTEMPTING TO LOAD PLUGIN SKILL: skill-ovos-news.openvoiceos
Jan 13 12:23:14 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:14.453 - skills - ovos_workshop.skill_launcher:_communicate_load_status:503 - INFO - Skill skill-ovos-news.openvoiceos loaded successfully
Jan 13 12:23:14 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:14.456 - skills - ovos_workshop.skill_launcher:load:525 - INFO - ATTEMPTING TO LOAD PLUGIN SKILL: skill-ovos-fallback-unknown.openvoiceos
Jan 13 12:23:14 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:14.919 - skills - ovos_workshop.skills.fallback:register_fallback:420 - INFO - registering fallback handler -> ovos.skills.fallback.skill-ovos-fallback-unknown.openvoi>
Jan 13 12:23:14 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:14.931 - skills - ovos_workshop.skill_launcher:_communicate_load_status:503 - INFO - Skill skill-ovos-fallback-unknown.openvoiceos loaded successfully
Jan 13 12:23:17 OpenVoiceOS-840dca ovos-core[9967]: 2024-01-13 12:23:17.897 - skills - ovos_core.intent_services.padatious_service:train:145 - INFO - Training complete.
Jan 13 12:23:46 OpenVoiceOS-840dca systemd[525]: Started OpenVoiceOS Core Service.
Jan 13 12:23:46 OpenVoiceOS-840dca ovos-core[9956]: fddc8803111ce4af5670ca9ce101f8c938507d12c9f5e56e337d60f484cd2594

@JarbasAl JarbasAl added the refactor code improvements with no functional changes label Jan 13, 2024
@JarbasAl JarbasAl merged commit 850890e into dev Jan 13, 2024
6 of 7 checks passed
@JarbasAl JarbasAl deleted the refactor/orjson branch January 13, 2024 12:34
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j1nx j1nx j1nx approved these changes

@mikejgray mikejgray Awaiting requested review from mikejgray

@NeonDaniel NeonDaniel Awaiting requested review from NeonDaniel

@goldyfruit goldyfruit Awaiting requested review from goldyfruit

@builderjer builderjer Awaiting requested review from builderjer

Assignees
No one assigned
Labels
refactor code improvements with no functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JarbasAl @j1nx