Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/ovos-media #78

Merged
merged 6 commits into from
Jan 12, 2024
Merged

feat/ovos-media #78

merged 6 commits into from
Jan 12, 2024

Conversation

NeonJarbas
Copy link
Contributor

@NeonJarbas NeonJarbas commented Jan 11, 2024 •
edited by JarbasAl
Loading

feat/ovos-media

  • add some missed methods in the OCPInterface class
  • add low level apis for ovos-media
  • support MediaEntry and Playlist objects in the apis
  • fix OCPQuery , results filtering is done in ovos-media

needs OpenVoiceOS/ovos-utils#218

JarbasAl and others added 2 commits January 11, 2024 23:34
@JarbasAl
feat/OCP
e637b82 
- add some missed methods in the OCPInterface class
- add apis for ovos-media
- support MediaEntry and Playlist objects in the apis
@NeonJarbas
Merge branch 'dev' into feat/supportMediaEntryPlaylist
286f68f
@codecov Codecov
Copy link

codecov bot commented Jan 11, 2024 •
edited
Loading

Codecov Report

Attention: 226 lines in your changes are missing coverage. Please review.

Comparison is base (9bc9ae8) 35.84% compared to head (98d2c71) 32.96%.
Report is 2 commits behind head on dev.

Files Patch % Lines
ovos_bus_client/apis/ocp.py 0.00% 225 Missing ⚠️
ovos_bus_client/version.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev      #78      +/-   ##
==========================================
- Coverage   35.84%   32.96%   -2.88%     
==========================================
  Files          17       17              
  Lines        1914     2081     +167     
==========================================
  Hits          686      686              
- Misses       1228     1395     +167

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NeonJarbas NeonJarbas marked this pull request as ready for review January 11, 2024 23:38
@NeonJarbas NeonJarbas changed the title fix/ocp api feat/ovos-media Jan 11, 2024
@JarbasAl JarbasAl added the enhancement New feature or request label Jan 11, 2024
@JarbasAl JarbasAl merged commit 7bf4704 into OpenVoiceOS:dev Jan 12, 2024
5 of 6 checks passed
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NeonJarbas @JarbasAl