refactor/remove_stt+tts_prefs #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeper changes are needed in listener/audio to support this properly, removing from session until this is more fleshed out there will be some overlap with user_id later and maybe makes more sense to retrieve this out of bounds instead of passing full plugin configs in message.context perhaps in the future ovos-audio/listener can load multiple plugins at once and this functionality restored
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deeper changes are needed in listener/audio to support this properly, removing from session until this is more fleshed out
there will be some overlap with user_id later and maybe makes more sense to retrieve this out of bounds instead of passing full plugin configs in message.context.
perhaps in the future ovos-audio/listener can load multiple plugins at once and this functionality restored
these were present for a short amount of time and didnt make it into a stable ovos release, however they made it into bus-client 0.0.7. This would accommodate Neon user prefs but since Neon did not adopt this the partial implementation can be removed (nothing else in OVOS integrated this yet)