fix/remove_broken_patch

ovos_config/config.py

@@ -54,10 +54,6 @@ class Configuration(dict):
     _callbacks = []
 
     def __init__(self):
-        # python does not support proper overloading
-        # when instantiation a Configuration object (new style)
-        # the get method is replaced for proper dict behaviour
-        self.get = self._real_get
         super().__init__(**self.load_all_configs())
 
     # dict methods
@@ -378,17 +374,6 @@ def patch_clear(message):
         Configuration.__patch = {}
 
     # Backwards compat methods
-    @staticmethod
-    def get(configs=None, cache=True, remote=True):
-        """DEPRECATED - use Configuration class instead"""
-        LOG.warning("Configuration.get() has been deprecated, use Configuration() instead")
-        # NOTE: this is only called if using the class directly
-        # if using an instance (dict object) self._real_get is called instead
-        return Configuration.load_config_stack(configs, cache, remote)
-
-    def _real_get(self, key, default=None):
-        return self.__getitem__(key) or default
-
     @staticmethod
     def clear_cache(message=None):
         """DEPRECATED - there is no cache anymore """

test/unittests/test_configuration.py

@@ -39,15 +39,6 @@ def tearDown(self):
         Configuration.load_config_stack([{}], True)
         Configuration._callbacks = []
 
-    def test_get(self):
-        from ovos_config.config import Configuration
-        d1 = {'a': 1, 'b': {'c': 1, 'd': 2}}
-        d2 = {'b': {'d': 'changed'}}
-        d = Configuration.get([d1, d2])
-        self.assertEqual(d['a'], d1['a'])
-        self.assertEqual(d['b']['d'], d2['b']['d'])
-        self.assertEqual(d['b']['c'], d1['b']['c'])
-
     @patch('mycroft.api.DeviceApi')
     @skip("requires backend to be enabled, TODO refactor test!")
     def test_remote(self, mock_api):