Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the config merge/load order #27

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

emphasize
Copy link
Member

This changes the load/merge order to:
USER > SYSTEM > REMOTE > DEFAULT

@JarbasAl
Copy link
Member

see MycroftAI/mycroft-core#2861

not sure how this bug made it over here as it was extensively discussed an unwanted to make remote > system

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

❗ No coverage uploaded for pull request base (dev@b3519ed). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             dev     #27   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?       9           
  Lines          ?     547           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?     547           
  Partials       ?       0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@emphasize
Copy link
Member Author

not sure how this bug made it over here as it was extensively discussed an unwanted to make remote > system

additionally, the former test masked the problem

Copy link
Member

@NeonDaniel NeonDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and tested to work under a recent Neon image. Unit test failures are related to a setuptools vulnerability and out of scope of this PR

@NeonDaniel NeonDaniel mentioned this pull request Mar 1, 2023
93 tasks
Copy link

@ChanceNCounter ChanceNCounter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right, I remember the original discussion, I concur it’s needed and Daniel has manually tested.

@JarbasAl JarbasAl added the bug Something isn't working label Mar 1, 2023
@JarbasAl JarbasAl merged commit eacd3e2 into OpenVoiceOS:dev Mar 1, 2023
@emphasize emphasize deleted the fix/load_order branch March 1, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants