Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add adapt match levels #402

Merged
merged 10 commits into from
Jan 24, 2024
Merged

Conversation

emphasize
Copy link
Member

@emphasize emphasize commented Jan 23, 2024

Problem: The Adapt matcher matching unrestricted.

As with the other services, 3 (configurable) threshold matcher are added to the pipeline for finegrained adjustability.
One thing in question, is the config option (key context) what we want?

Companion PR (config): OpenVoiceOS/ovos-config#100

@emphasize
Copy link
Member Author

the rest of the failing unittest should go back to the config defaults in ovos-config

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (cf8b6b5) 62.72% compared to head (a67dd4c) 63.49%.
Report is 1 commits behind head on dev.

Files Patch % Lines
ovos_core/intent_services/adapt_service.py 92.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #402      +/-   ##
==========================================
+ Coverage   62.72%   63.49%   +0.77%     
==========================================
  Files          14       14              
  Lines        2039     2063      +24     
==========================================
+ Hits         1279     1310      +31     
+ Misses        760      753       -7     
Flag Coverage Δ
unittests 63.49% <93.10%> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goldyfruit
Copy link
Member

Works for me!

@JarbasAl JarbasAl merged commit 8bba0aa into OpenVoiceOS:dev Jan 24, 2024
9 of 10 checks passed
JarbasAl added a commit to OpenVoiceOS/ovos-bus-client that referenced this pull request Jan 29, 2024
edge case when config is missing / older ovos-config installed

sync with OpenVoiceOS/ovos-core#402
JarbasAl added a commit to OpenVoiceOS/ovos-bus-client that referenced this pull request Jan 29, 2024
edge case when config is missing / older ovos-config installed

sync with OpenVoiceOS/ovos-core#402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants