Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/fake-barge-in #109

Merged
merged 5 commits into from
Apr 15, 2024
Merged

feat/fake-barge-in #109

merged 5 commits into from
Apr 15, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Apr 15, 2024

lowers global volume during recording, to ensure OVOS can hear the user

  • when a volume message is detected -> track default volume (set by user)
  • when recording starts -> lower volume
  • when recording ends -> restore to previous default volume
{
  "listener": {
    "fake_barge_in": true,
    "barge_in_volume": 30
  }
}

NOTE: "barge_in_volume" from 0-100

lowers global volume during recording, to ensure OVOS can hear the user

```
{
  "listener": {
    "fake_barge_in": true,
    "barge_in_volume": 30
  }
}
```
@JarbasAl JarbasAl added the enhancement New feature or request label Apr 15, 2024
@JarbasAl JarbasAl requested review from goldyfruit, emphasize and a team April 15, 2024 02:42
@goldyfruit
Copy link
Member

Working for me, volume goes from 80% to 30% when record begins and got back to 80% when record ends.

@JarbasAl JarbasAl merged commit 0f5a854 into dev Apr 15, 2024
9 checks passed
@JarbasAl JarbasAl deleted the feat/fake-barge-in branch April 15, 2024 18:50
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants