Update features.sh #108
Update features.sh #108
Conversation
|
@Vaibhav-Magadum Thanks for the PR. Could you please update as well all the other languages? |
WalkthroughThe updates to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- tui/locales/en-us/features.sh (1 hunks)
Additional comments not posted (5)
tui/locales/en-us/features.sh (5)
4-4: LGTM!The context provided for choosing between enabling the GUI and loading skills is clear and enhances user understanding.
6-6: LGTM!The description of the GUI as an additional visual layer for easier interaction is clear and accurate.
8-8: LGTM!The description of skills as enabling interaction through speech for various tasks is clear and accurate.
13-13: LGTM!The update from "OVOS" to "Open Voice OS" in the description of loading default skills improves clarity.
14-14: LGTM!The update from "OVOS" to "Open Voice OS" in the description of loading extra skills improves clarity.
|
@goldyfruit sure I would update.Can I add the link of documentation to point on what "extra skills" are..!? |
|
Links are hard to manage via TUI. |
|
I didn't mean to bog this PR down with the baggage of defining what extra skills are. I was looking at the same screen and thought it'd be appropriate "while we're in there". Just wanted to call out as a new user it's pretty meaningless - I have no intuition what enabling "extra skills" is intended to do or what I miss out on by keeping it disabled. |
|
perhaps "essential" skills would help understanding the difference, "extras" is just more official OVOS skills but that are not critical and it's fine if missing |
|
Ok....now what are the final changes to be done..!? |
I would propose just this change, instead of default, that gives a better picture of what extra skills are |
|
maybe also rename extra to optional?
@tobymurray would this sound better and help clearing confusion? further explanations should be added in separate documentation, in general i think we need a Getting Started guide that covers this sort of stuff in more depth. @goldyfruit maybe a note and url can be added in the tutorial you wrote |
|
I don't want to hold up this PR, everything seems like an improvement.
Honestly - no. If they're "essential" it's not clear as a user why I would be deselecting them ever and "extra"/"additional" etc. is meaningless without exposure to the ecosystem enough to intuitively understand what that would encompass. I imagine it's hard to go back to not knowing what this stuff refers to, but if I were to sell you a car and say "for 1000$ more I'll throw in some extras" I think most people's first question would be "... well, what are the extras?" If we can't explain what these skill are broadly, then I think the second best option would be to suggest why one would choose them. What is the use case for a user not selecting the default OVOS skills? Is this like Raspbian-full vs. Rasbian-lite? Riffing on that, could go more in the direction of e.g. (just making things up): Thoughts:
Definitely that seems like a worthwhile resource. |
this question is very valid and has a lot of nuances if you think about arch linux where a user makes their OS from scratch, this would be the equivalent of installing OVOS with no skills, as a power user you would curate exactly which skills you want. Besides this sort of power user, this also allows downstream to automate the install and use their own skills better suited for their use case. So the answer to "are these required" is no... but the answer to "does it make sense to prompt for the default at all?" is more complex. If we want to specifically target new users as the main audience, maybe we should not prompt about default skills at all, but if the goal is for the installer to be flexible for more use cases then it should remain as an option. In the case of automated installs usually there is no prompting, it's a config file, so perhaps we can just omit the option from the TUI but still support it? I'm sure we can find something in between, let's open an issue to continue the discussion there
not really, technically valid but i don't see why someone would do that in practice |
|
@tobymurray please open a PR with your changes and I will review them. 👍 |
|
@Vaibhav-Magadum are you still working on this PR? |
|
@goldyfruit I have examination going in my college so I would get back once they get over....!!! |
Ohhhhh take all the time you need, no rush and school first! Good luck! 🤞 🍀 |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- tui/locales/en-us/features.sh (1 hunks)
- tui/locales/hi-in/features.sh (1 hunks)
Files skipped from review due to trivial changes (1)
- tui/locales/hi-in/features.sh
Additional comments not posted (3)
tui/locales/en-us/features.sh (3)
4-4: Improved clarity in user instructions.The updated description helps users better understand the difference between enabling the GUI and loading skills.
6-6: Enhanced description of the GUI.The updated description clarifies the role of the GUI as an additional visual layer for easier interaction.
13-14: Clearer descriptions for essential and extra skills.The updated descriptions provide better clarity on the role of essential and extra skills, aiding user understanding.
|
@goldyfruit @JarbasAl @tobymurray I have Update the PR.....!! |
| GUI_DESCRIPTION="ग्राफिकल यूजर इंटरफेस (GUI) इस्तमाल करें" | ||
| TITLE="ओपन वॉयस ओएस इंस्टालेशन - विशेषताएं" | ||
| SKILL_DESCRIPTION="बुनियादी कार्यक्षमता के लिए आवश्यक ओपन वॉयस ओएस कौशल लोड करें" | ||
| EXTRA_SKILL_DESCRIPTION="व्यापक अनुभव के लिए अतिरिक्त ओपन वॉयस ओएस कौशल (वैकल्पिक) सेट लोड करें" |
There was a problem hiding this comment.
बेहतर अनुभव के लिए अतिरिक्त ओपन वॉयस ओएस कौशल (वैकल्पिक) सेट लोड करें।
This is more easy to understand
| SKILL_DESCRIPTION="डिफ़ॉल्ट OVOS कौशल लोड करें" | ||
| EXTRA_SKILL_DESCRIPTION="अतिरिक्त OVOS कौशल लोड करें" | ||
| GUI_DESCRIPTION="ग्राफिकल यूजर इंटरफेस (GUI) इस्तमाल करें" | ||
| TITLE="ओपन वॉयस ओएस इंस्टालेशन - विशेषताएं" |
There was a problem hiding this comment.
it should be विशेषताएँ not विशेषताएं
All of them I guess. Feel free to use Deepl to translate some parts. |
|
@goldyfruit deeply doesn't support Hindi language...I will look for another alternative..!! An changes necessary in English part .!? |
|
@Vaibhav-Magadum English version looks good to me. |
|
Closing due to #161 |
#98 Updated the features to make it easy to understand for new users.
Summary by CodeRabbit
Documentation
Style