Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language plugin factories #10

Merged
merged 2 commits into from
Nov 12, 2021
Merged

language plugin factories #10

merged 2 commits into from
Nov 12, 2021

Conversation

NeonJarbas
Copy link
Contributor

since we ported all factories for plugins into OPM, we should also have the neon factories for consistency

@JarbasAl JarbasAl added the enhancement New feature or request label Nov 10, 2021
@ChanceNCounter
Copy link

I don't know what I'm looking at but I know it contains multiple, manual references to compatible software that will be hard to maintain.

@JarbasAl
Copy link
Member

JarbasAl commented Nov 11, 2021

I don't know what I'm looking at but I know it contains multiple, manual references to compatible software that will be hard to maintain.

these are just aliases for official plugins, we do the same for mycroft plugins (and have a TODO for every engine in mycroft-core not yet pluginified).

It just continues the paradigm of officially supported vs 3rd party code. All those are code owned by us

This does bring up a good point, what makes a plugin official?

these are not under the OVOS org, but those are our direct upstream. I think if something is our upstream it counts as officially supported, this is functionality "donated" by neon.

To clarify the use case, it's all about language support, think ddg and wolfram alpha skills. Each skill calls the factory instead of mycroft-core

@JarbasAl JarbasAl merged commit ea841db into OpenVoiceOS:master Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants