Feat/g2p plugins #21
Merged
Feat/g2p plugins #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarbasAl
added a commit
that referenced
this pull request
Dec 2, 2021
NeonDaniel
approved these changes
Dec 16, 2021
Member
NeonDaniel
left a comment
NeonDaniel
left a comment
There was a problem hiding this comment.
Did not test; left minor comment on version specs for dependencies
Closed
JarbasAl
added a commit
that referenced
this pull request
Feb 3, 2022
JarbasAl
added a commit
that referenced
this pull request
Feb 3, 2022
PR merged too early and missing this commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes the phoneme_guesser modular, it can now be replaced with something better like gruut
the default usage was with phoneme_guesser which is a few MB because of bundled dicts, the new suggested default is the cmudict plugin which only gets phonemes for known words
this is only used to generate the mouth movements / viseme messages
support in plugins + automatic conversion was implemented for ipa and arpa alphabets, ARPA is expected by core
a companion PR should be done in ovos_utils to deprecate the get_phonemes utils
plugins:
companion PR:
OpenVoiceOS/awesome-ovos-plugins#1
OpenVoiceOS/ovos-utils#11