Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

german locale revision #20

Closed
wants to merge 15 commits into from
Closed

Conversation

emphasize
Copy link
Member

@emphasize emphasize commented Feb 25, 2023

Initial changes:

  • review translation

dependent on #19 (value change)

@emphasize
Copy link
Member Author

emphasize commented Feb 25, 2023

latest commit changed the langdefault since it tests for self.lang (corrected for it and es as well)

As a sidenote is_default only gets set with your own language (self.lang), but should be set for every lang

@emphasize
Copy link
Member Author

emphasize commented Feb 25, 2023

pls wait with the merger as i address said is_default issue alongside

@emphasize
Copy link
Member Author

emphasize commented Feb 25, 2023

changes:

  • lang2news feeds are now defined with the full lang code across the board
  • default feeds are now set for every language. Ie. if one issues a feed from a foreign language (and no feed name/alias is uttered) the default is prioritized.

@JarbasAl
Copy link
Member

one more rebase please

@emphasize emphasize requested a review from JarbasAl April 3, 2023 13:08
@emphasize
Copy link
Member Author

emphasize commented Apr 3, 2023

vscode can kiss my ass 🥇. Will make a new one resp. split it in two, this one is fucked.

@emphasize
Copy link
Member Author

closed in favor of #22 , #23

@emphasize emphasize closed this Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants