fix:requirements #21
fix:requirements #21
Conversation
follow semver to allow latest stable plugins
WalkthroughThe pull request introduces updates to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- requirements/requirements.txt (1 hunks)
🔇 Additional comments (3)
requirements/requirements.txt (3)
1-1: Approved: Version constraint update for ovos-plugin-managerThe change from
~=0.0.18to>=0.0.18,<1.0.0forovos-plugin-manageris a good improvement. This new constraint allows for a wider range of compatible versions while still maintaining an upper bound to prevent potential breaking changes from major version updates. This aligns well with the PR objective of using the latest stable plugins and adheres to Semantic Versioning principles.
5-5: Approved: Consistent version constraint update for ovos-utilsThe change from
~=0.0.32to>=0.0.32,<1.0.0forovos-utilsis consistent with the update made toovos-plugin-manager. This change allows for a wider range of compatible versions while still maintaining an upper bound, adhering to Semantic Versioning principles and supporting the use of the latest stable plugins.
6-6:⚠️ Potential issuePlease clarify the addition of Flask and consider adding a version constraint
The addition of
flaskas a new dependency raises a few questions:
- What is the purpose of adding Flask to this project? The PR objectives don't mention this addition.
- Why is there no version constraint specified for Flask?
It's generally recommended to specify version constraints for all dependencies to ensure reproducibility and avoid unexpected breaking changes. Consider adding a version constraint for Flask, such as
flask~=2.3.2(or the latest stable version that meets your requirements).Could you please provide more context on why Flask is being added and then add an appropriate version constraint?
| fastapi~=0.95 | ||
| uvicorn~=0.22 | ||
| gradio~=3.28 |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Consider updating version constraints for consistency
While the version constraints for fastapi, uvicorn, and gradio weren't changed in this PR, it might be worth considering updating them for consistency with the new approach used for ovos-plugin-manager and ovos-utils. The current constraints use the compatible release operator (~=), which is more restrictive than the new constraints.
For example, you might consider changing:
fastapi~=0.95tofastapi>=0.95,<1.0.0uvicorn~=0.22touvicorn>=0.22,<1.0.0gradio~=3.28togradio>=3.28,<4.0.0
This would allow for a wider range of compatible versions while still maintaining upper bounds to prevent potential breaking changes from major version updates. However, please carefully consider the stability and compatibility of these packages before making such changes.
follow semver to allow latest stable plugins
Summary by CodeRabbit
New Features
flaskas a new dependency to enhance functionality.Improvements
ovos-plugin-managerandovos-utilsto allow for more flexibility in updates.