Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add some trivial unit test coverage that log config changes are reacted to #253

Closed
JarbasAl opened this issue Jun 18, 2024 · 0 comments · Fixed by #260
Closed

add some trivial unit test coverage that log config changes are reacted to #253

JarbasAl opened this issue Jun 18, 2024 · 0 comments · Fixed by #260
Assignees
@NeonDaniel
Labels
tests and automation

Comments

@JarbasAl
Copy link
Member 

          Can you add some trivial unit test coverage that config changes are reacted to? (i.e. no reload if non-log config changed vs log re-init upon relevant config change). This should also resolve the failing codecov test

Originally posted by @NeonDaniel in #252 (comment)
NeonDaniel added a commit that referenced this issue Jul 16, 2024
@NeonDaniel
Add docstrings and type annotations to log module
88d3eab 
Add test coverage for log rotation
Outline test coverage for added log module functions
Relates to #2 #239 #233 #250 #253
@NeonDaniel NeonDaniel mentioned this issue Jul 16, 2024
Merged
JarbasAl pushed a commit that referenced this issue Sep 2, 2024
@NeonDaniel
log module unit test coverage (#260)
e4a3ff7 
* Add docstrings and type annotations to `log` module
Add test coverage for log rotation
Outline test coverage for added log module functions
Relates to #2 #239 #233 #250 #253

* Update logs to resolve order-related failure

* Add test coverage for `get_logs_config`
Refactor variable in `get_logs_config` for clarity
Refactor `get_logs_config` for more predictable handling of an empty service name

* Add test coverage for `get_log_path`

* Add test coverage for `get_log_paths`
Update `get_log_paths` to check all log names with `-` normalized to `_` (appeared to be the original intent)
Add `enclosure` and `admin` service logs used by Neon and legacy Mycroft/OVOS setups

* Add test coverage for `get_available_logs`

* Add test coverage for `_monitor_log_level`

* Add test of `get_config` call count

* Update `get_log_paths` to reference config directly instead of test some well-known values
Update unit test for `get_log_paths`

* Remove unused `ALL_SERVICES` variable

* Remove unused import

---------

Co-authored-by: Daniel McKnight <daniel@neon.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NeonDaniel NeonDaniel

Labels
tests and automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

log module unit test coverage OpenVoiceOS/ovos-utils
2 participants
@JarbasAl @NeonDaniel