You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Can you add some trivial unit test coverage that config changes are reacted to? (i.e. no reload if non-log config changed vs log re-init upon relevant config change). This should also resolve the failing codecov test
* Add docstrings and type annotations to `log` module
Add test coverage for log rotation
Outline test coverage for added log module functions
Relates to #2#239#233#250#253
* Update logs to resolve order-related failure
* Add test coverage for `get_logs_config`
Refactor variable in `get_logs_config` for clarity
Refactor `get_logs_config` for more predictable handling of an empty service name
* Add test coverage for `get_log_path`
* Add test coverage for `get_log_paths`
Update `get_log_paths` to check all log names with `-` normalized to `_` (appeared to be the original intent)
Add `enclosure` and `admin` service logs used by Neon and legacy Mycroft/OVOS setups
* Add test coverage for `get_available_logs`
* Add test coverage for `_monitor_log_level`
* Add test of `get_config` call count
* Update `get_log_paths` to reference config directly instead of test some well-known values
Update unit test for `get_log_paths`
* Remove unused `ALL_SERVICES` variable
* Remove unused import
---------
Co-authored-by: Daniel McKnight <daniel@neon.ai>
Originally posted by @NeonDaniel in #252 (comment)
The text was updated successfully, but these errors were encountered: