Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/detect_ovos_gui_app #258

Merged
merged 3 commits into from
Jul 5, 2024
Merged

fix/detect_ovos_gui_app #258

merged 3 commits into from
Jul 5, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Jul 5, 2024

account for the ovos maintained mycroft-gui fork when checking for running gui processes

account for the ovos maintained mycroft-gui fork when checking for running gui processes
@JarbasAl JarbasAl added the bug Something isn't working label Jul 5, 2024
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 42.27%. Comparing base (a05ab7b) to head (df3d1dd).
Report is 2 commits behind head on dev.

Files Patch % Lines
ovos_utils/gui.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #258      +/-   ##
==========================================
- Coverage   42.32%   42.27%   -0.06%     
==========================================
  Files          31       31              
  Lines        3213     3217       +4     
==========================================
  Hits         1360     1360              
- Misses       1853     1857       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit ce642ff into dev Jul 5, 2024
8 of 9 checks passed
@JarbasAl JarbasAl deleted the fix/detect_ovos_gui_app branch July 5, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant