reduce bus/log spam #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename methods for consistency (show/display/update_gui ... what a mess) - make the scheduled event update only mk1 faceplate, no need to spam the GUI bus every 10 seconds (this isnt the homescreen clock) - remove references to deprecated self.enclosure.display_manager - add settings changed callback, only send the repeating events if the setting is enabled, no need to spam debug logs otherwise! - rm create_skill deprecated function
builderjer
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename methods for consistency (show/display/update_gui ... what a mess)
make the scheduled event update only mk1 faceplate, no need to spam the GUI bus every 10 seconds (this isnt the homescreen clock)
remove references to deprecated self.enclosure.display_manager
add settings changed callback, only send the repeating events if the setting is enabled, no need to spam debug logs otherwise!
rm create_skill deprecated function
drop .qml file extension from pages, preparing for alternative GUIs support
move ui folder to qt5 , further silencing logs
remove dead files and outdated automations (skill.json)