Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypi ready #2

Merged
merged 4 commits into from
Sep 5, 2023
Merged

pypi ready #2

merged 4 commits into from
Sep 5, 2023

Conversation

emphasize
Copy link
Member

Let's get this one rolling

  • autotranslated
  • tests for
    • osm
    • skill behaviour (loader, intents, featured media, search)
  • workflows

@emphasize
Copy link
Member Author

emphasize commented Sep 3, 2023

Few things about failing tests:
First off, the pulled package tunein # has to be bumped to .3 (that has to be reflected in requirements.txt)
Regarding to that i found that 0.0.3a1 (--pre) of said package points to an earlier commit (commit not included)
-> failing SkillTest
locally passing

@mikejgray
Copy link

Installed on RaspOVOS and Neon Mark 2, cannot get it to play with either test intent in the README. Removed conflicting SomaFM skill, same results.

@emphasize
Copy link
Member Author

emphasize commented Sep 4, 2023

Stated above it would need tunein to get a bump or manually adding OpenJarbas/tunein@a66bedb (w/o, the generator is just empty)

Featured media (ie playlist per gui widget) would work though

@emphasize
Copy link
Member Author

emphasize commented Sep 4, 2023

But good call, the examples are somewhat BS with this skill (seems copy/paste). Your asking for a radio station.
Heavy Metal query would bring up stations, but we should show a station example rather than a genre
(add. "radio" - as far as i can tell - gets removed by OCP)

Removed conflicting SomaFM skill, ....

There should be no conflict. This is just a generator producing scored media entries. Maybe you want to expand on that?

@goldyfruit
Copy link
Member

The skill loads but I got this trace when asking for "play heavy metal radio":

2023-09-05 14:56:10.432 - OVOS - ovos_workshop.skill_launcher:_communicate_load_status:506 - INFO - Skill skill-ovos-tunein.openvoiceos loaded successfully
Exception ignored in: <generator object TuneIn._get_stations at 0x7f194bc5ddf0>
Traceback (most recent call last):
  File "/home/ovos/.venv/lib/python3.11/site-packages/tunein/__init__.py", line 71, in search
    yield from TuneIn._get_stations(res, query)
RuntimeError: generator ignored GeneratorExit
Exception ignored in: <generator object TuneIn.search at 0x7f194b6e89e0>
Traceback (most recent call last):
  File "/home/ovos/.venv/lib/python3.11/site-packages/tunein/__init__.py", line 71, in search
    yield from TuneIn._get_stations(res, query)
RuntimeError: generator ignored GeneratorExit

@emphasize
Copy link
Member Author

get the same generator exception, but it ultimately plays the station. Will investigate

@emphasize
Copy link
Member Author

emphasize commented Sep 5, 2023

For the -not skill related- looping situation, @JarbasAl pls have a look at this log and this log (docker environment)
can`t decipher what is happening there

@goldyfruit
Copy link
Member

goldyfruit commented Sep 5, 2023

For the -not skill related- looping situation, @JarbasAl pls have a look at this log and this log can`t decipher what is happening there

Can't stop the loop xD The only way is too restart ovos_audio container.

JarbasAl added a commit to OpenJarbas/tunein that referenced this pull request Sep 5, 2023
@JarbasAl JarbasAl mentioned this pull request Sep 5, 2023
@goldyfruit
Copy link
Member

goldyfruit commented Sep 5, 2023

With the latest tunein release I don't get the trace anymore, but still loop in audio and no music.

@emphasize
Copy link
Member Author

This is not skill related, so should be discussed elsewhere

@JarbasAl JarbasAl merged commit 6cb5ff2 into dev Sep 5, 2023
9 checks passed
@JarbasAl JarbasAl deleted the feat/pypi_ready branch September 5, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants