Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix adapt entities #33

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Conversation

emphasize
Copy link
Member

@emphasize emphasize commented Apr 5, 2023

Problem:

  • If defined capitalized the key created in message.data is also capitalized. location is accessed lowercase. To be consistent all entity references were defined lowercase.
    self.location = message.data.get("location")
  • The still existing CamelCase references were brought in line with the voc filename stem. Personally i don't know if camelcase is resolved in adapt, but its something hidden in the code that is just unnecessary. (and weather forcast intents already do it like that)

this only affected condition requests, that's why it must have slipped through the cracks

@emphasize emphasize requested a review from JarbasAl April 5, 2023 13:16
@JarbasAl
Copy link
Member

JarbasAl commented Apr 6, 2023

historically the pattern has been to use CamelCase, but that is not a requirement and skills in the wild vary greatly, when this skill "was made great again" i suppose these were missed

@JarbasAl JarbasAl merged commit 534654c into OpenVoiceOS:dev Apr 6, 2023
@JarbasAl JarbasAl added the bug Something isn't working label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants