Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add time specific requests #51

Merged
merged 1 commit into from
Aug 15, 2023
Merged

add time specific requests #51

merged 1 commit into from
Aug 15, 2023

Conversation

emphasize
Copy link
Member

@emphasize emphasize commented Jun 5, 2023

Problem:

hourly weather is atm restricted to daytime requests (noon/afternoon/evening/morning/night/midnight)

this parses the intent datetime and based on this the timeframe is chosen.
consolidates weather intents into one routing the intents to the appropriate handler

@emphasize emphasize added the enhancement New feature or request label Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #51 (5f69d7b) into dev (e2add03) will decrease coverage by 0.43%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##              dev      #51      +/-   ##
==========================================
- Coverage   26.57%   26.14%   -0.43%     
==========================================
  Files           8        8              
  Lines        1095     1090       -5     
==========================================
- Hits          291      285       -6     
- Misses        804      805       +1     
Flag Coverage Δ
unittests 26.14% <22.22%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
weather_helpers/intent.py 36.92% <0.00%> (-0.58%) ⬇️
__init__.py 25.36% <23.52%> (-1.08%) ⬇️

@emphasize emphasize self-assigned this Jun 5, 2023
@JarbasAl JarbasAl merged commit 817e479 into dev Aug 15, 2023
@JarbasAl JarbasAl deleted the add/time_specific_requests branch August 15, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants