This repository has been archived by the owner on Oct 24, 2021. It is now read-only.
new patch - remove_voc #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JarbasAl
commented
Dec 31, 2020
•
JarbasAl
commented
- moves remove_voc utility function from template skill to base skill, new patch in the lines of waiting_for_mycroft #15
- NOTE: PR not yet made to mycroft-core
- moves datestr2ts util function from template skill to top level module, its useful in more places
- fix bug in media collection template skill (duration might be missing)
- recommend better version of py_vod, there is an issue in previous (video only, no audio)
JarbasAl
added
enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.