Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: "Other" IR Devices send incorrect commands if repeated #314

Closed
jonzhan opened this issue Apr 15, 2022 · 2 comments
Closed

Bug: "Other" IR Devices send incorrect commands if repeated #314

jonzhan opened this issue Apr 15, 2022 · 2 comments
Assignees
Labels
bug Something isn't working stale

Comments

@jonzhan
Copy link

jonzhan commented Apr 15, 2022

Describe The Bug

"Other" IR Devices send incorrect commands if repeated

To Reproduce

Try to turn off an "Other" IR device which is already off. It will turn on.

Expected behavior

Nothing should happen or the Off command should be retransmitted.

Relevant log output

[15/04/2022, 19:24:51] [SwitchBot] Other: Aircon Sending request to SwitchBot API. command: Off, parameter: default, commandType: customize
[15/04/2022, 19:25:15] [SwitchBot] Other: Aircon Sending request to SwitchBot API. command: On, parameter: default, commandType: customize

Config for homebridge-switchbot

{
    "deviceId": "xxxxxxxxx",
    "configRemoteType": "Fan",
    "other": {
        "deviceType": "Fan",
        "commandOff": "Off",
        "commandOn": "On"
    },
        "logging": "debug"
}

Screenshots

No response

Device & Model

Raspberry Pi 3

Node.js Version

v16.13.0

NPM Version

v8.1.0

Homebridge Version

v1.4.0

Homebridge Switchbot Plugin Version

v1.12.8

Homebridge Config UI X Plugin Version

v4.42.0

Operating System

Raspbian

@jonzhan jonzhan added the bug Something isn't working label Apr 15, 2022
donavanbecker pushed a commit that referenced this issue Apr 20, 2022
@jonzhan jonzhan changed the title Bug: Bug: "Other" IR Devices send incorrect commands if repeated Apr 20, 2022
jonzhan added a commit to jonzhan/homebridge-switchbot that referenced this issue Apr 20, 2022
Reinstated checks to avoid sending On and Off IR Commands to "Other" devices only if they are not already in the target state.
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2022

This issue has been automatically closed because it has not had recent activity. Thank you for your contributions.

@github-actions github-actions bot closed this as completed May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

2 participants