Fixes #310 "Other" IR Devices send commandOn and commandOff at reversed times #311
Conversation
## [Version 1.12.8](https://github.com/OpenWonderLabs/homebridge-switchbot/releases/tag/v1.12.8) (2022-03-19) ## What's Changed - Housekeeping and updated dependencies. **Full Changelog**: OpenWonderLabs/homebridge-switchbot@v1.12.7...v1.12.8
Swapped calls to pushOffChanges and pushOnChanges and inverted downstream checks for this.Active
Fix for "Other" IR devices sending reversed On/Off commands
|
I have pushed this to beta. you can test this on the latest beta version and let me know if it works for you? |
|
Thank you, I can confirm that this works on v1.12.9-beta.23! |
|
@jonzhan awesome! I will release and update soon |
|
Great. Thank you! |
|
@donavanbecker I found another related bug (close enough that I don't think it needs another issue) - right now the code assumes that any instruction is a toggle of the device's state, so it works fine with simple switches but may send the wrong signal when using scenes. I can cook up a fix, but I would like to ask for your input on what the desired behavior should be. If, for example, a device is already "off" and a scene tries to turn the device off again, would you prefer that:
|
|
I guess we could make a config that would say do you want 1 or do you want 2 then users can choose. |
|
It’s certainly an option! Have you received feedback from other users who would prefer the “always transmit” functionality instead?
… On 12 Oct 2022, at 1:21 PM, Donavan Becker ***@***.***> wrote:
I guess we could make a config that would say do you want 1 or do you want 2 then users can choose.
—
Reply to this email directly, view it on GitHub <#311 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACK4RNQLTLVWVH4V763E3WCZDEBANCNFSM5TFWFX2Q>.
You are receiving this because you were mentioned.
|
|
Yes I have. I actually have a config called allow push for one of the other devices. But it's a SwitchBot device not Ir, so might as well add it. So we do not send, and only send when |
|
@jonzhan if you wanna put a PR together. I will ad the |
|
@donavanbecker Sounds good. I'll get a PR over in a day or so! |
|
No rush. Also have you upgraded to v2.0.0? |
|
Ooh no, I didn’t realize there was a point release. Nice! Good to have the BLE fallback.
… On 13 Oct 2022, at 8:38 PM, Donavan Becker ***@***.***> wrote:
No rush. Also have you upgraded to v2.0.0?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
|
that was always there before but kinda changed things up on it. |
|
I upgraded to 2.0 but unfortunately it has broken my IR devices, whoops! I'll make a separate ticket and circle back to this after that's figured out. |
|
@jonzhan V2.1.0 should have fixed that? |
|
hmm unfortunately not - I have also tried v2.1.1-beta.0 with no luck!
… On 14 Oct 2022, at 6:59 PM, Donavan Becker ***@***.***> wrote:
@jonzhan <https://github.com/jonzhan> V2.1.0 should have fixed that?
—
Reply to this email directly, view it on GitHub <#311 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACK4VLPYBERSIBF6RRP2DWDE4K5ANCNFSM5TFWFX2Q>.
You are receiving this because you were mentioned.
|
|
@jonzhan sorry. Okay once you open the ticket I will take a look. |
|
No worries, wonder what it is! Created #520 |
|
I've made a bunch of changes to support |
|
Okay latest beta should have the right change... I think. |
As far as I can tell this fix makes sense but I have no idea how to test it on my local setup, sorry.