-
Notifications
You must be signed in to change notification settings - Fork 29
Fixed 'TypeError: Assignment to constant variable'. #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dnicolson Can you review? |
|
@banboobee Can you rebranch to beta-1.8.2 branch? |
|
Looks good to me. |
|
@banboobee thanks for the original fix, I've included it with other similar issues in #196. @donavanbecker can you please look at the remaining lint issues in #195? There should be only 5 linting issues left. |
|
Re-branched. I didn't know the beta-branch, but now find that it intends to identical with this PR. omg, I wasted a lot of time. This PR also added the support for meter-plus device. |
|
@banboobee I think you'll want to do a rebase over the There is still the problematic second instance here: I've included it with other fixes here though: |
|
@donavanbecker this merge ( @banboobee could you maybe create a new PR with the meter-plus changes? |
|
@banboobee, I am about to release the next version. Any chance you can create a new PR so that I can merge it into this version? |
|
What do you mean? New PR for meter-plus? It is included in this PR. |
|
@banboobee So does the latest version resolve your issues? |
|
Yes. With v1.8.1, meter and meter-plus are stopped working for these three months. @gravity-addiction fixed for meter in #191, and #194 (this PR) added the fix for meter-plus. So, v1.8.2 fixed both issues. meter and meter-plus are working again, I believe. |
Fixed run-time error 'TypeError: Assignment to constant variable' for meter devices. #184 introduced this bug.