Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The documentation for the set RGB on the color bulb is incorrect #34

Open
AdyRock opened this issue Jan 2, 2022 · 1 comment
Open

Comments

@AdyRock
Copy link

AdyRock commented Jan 2, 2022

Analysis

The documentation for the command to change the RGB value is incorrect.
The column shows BYTE 3 is the Lvl but it is actually the Red colour. That in turn offsets the Green and Blue.

Expected Behavior

From the document I expect that sending [0x47, 0x01, 0x16, 0x32, 0xFF, 0x00, 0x00] would set the light to red and 50% brightness.
It actually sets it to a red / green colour.

Sending [0x47, 0x01, 0x16, 0xFF, 0x00, 0x00] does actually set red.

Steps To Reproduce

Send [0x47, 0x01, 0x16, 0x32, 0xFF, 0x00, 0x00] the colour is red / green

Send [0x47, 0x01, 0x16, 0xFF, 0x00, 0x00] the colour is red.

Logs

No logs are required.

Configuration

No config

Environment

  • OS: N/A
  • Software: N/A
  • Node: 12
  • npm: N/A

Additional Context

image

@devWaves
Copy link

devWaves commented Jan 2, 2022

@AdyRock

from quick testing:

If you want Brightness and RGB you would do... (using 0x12)
[0x57, 0x0F, 0x47, 0x01, 0x12, 0x32, 0xFF, 0x00, 0x00]

if you want just RGB (no brightness) you would do... (using 0x16)
[0x57, 0x0F, 0x47, 0x01, 0x16, 0xFF, 0x00, 0x00]

So yes the documentation is a little incorrect. good luck. I just started looking at implementing the bulb for my ESP32 code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants