Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Clear Sky] Crash when picking a quest for flash drives from a technician #1786

Closed
0xA50C1A1 opened this issue Feb 7, 2025 · 2 comments · Fixed by #1787
Closed

[Clear Sky] Crash when picking a quest for flash drives from a technician #1786

0xA50C1A1 opened this issue Feb 7, 2025 · 2 comments · Fixed by #1787
Labels
Bug The issue in the run-time. Clear Sky This can affect Clear Sky compatibility, or related to this game.

Comments

@0xA50C1A1
Copy link

Describe the bug

A crash occurs when I try to pick a side quest from the technicians to find flash drives. I noticed this bug months ago and reported it on Discord, but it still hasn't fixed.

To Reproduce
Steps to reproduce the behavior:

  1. Talk to any technician, for example, Novikov.
  2. Pick the quest to find the flash drives.
  3. See error

BugTrap error report

openxray_vladimir.log

Desktop (please complete the following information):

  • OS: Ubuntu 24.04
  • OpenXRay build version: nightly

Additional context

FATAL ERROR
 
[error] Expression    : uiXml.NavigateToNode(path_base, 0)
[error] Function      : LoadSpot
[error] File          : /home/runner/work/xray-16/xray-16/src/xrGame/map_location.cpp
[error] Line          : 70
[error] Description   : XML node not found in file map_spots.xml
[error] Arguments     : secondary_task_location_complex_flesh_up_a_novice_outfit
@0xA50C1A1 0xA50C1A1 added the Bug The issue in the run-time. label Feb 7, 2025
@Xottab-DUTY Xottab-DUTY moved this to To do in Roadmap Feb 7, 2025
@Xottab-DUTY Xottab-DUTY added the Clear Sky This can affect Clear Sky compatibility, or related to this game. label Feb 7, 2025
@Xottab-DUTY
Copy link
Member

The crash was introduced with #1515.

AMS21 added a commit to AMS21/xray-16 that referenced this issue Feb 7, 2025
@AMS21
Fix XMLDocument includes failing to parse if missing a closing quote.
fe98b4e 
Although it's a bit weird, it's required to successfully parse some of the
original Clear Sky XML files.

Fixes OpenXRay#1786
@AMS21 AMS21 mentioned this issue Feb 7, 2025
Merged
@github-project-automation github-project-automation bot moved this from To do to Done in Roadmap Feb 7, 2025
@github-project-automation github-project-automation bot moved this from To do to Done in Roadmap Feb 7, 2025
@0xA50C1A1
Copy link
Author

@AMS21 tyvm, now it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug The issue in the run-time. Clear Sky This can affect Clear Sky compatibility, or related to this game.
Projects
Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix XMLDocument includes failing to parse if missing a closing quote. AMS21/xray-16
2 participants
@Xottab-DUTY @0xA50C1A1