-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiling #3
Comments
First of all, I would like to use my CS repository style here (docs, version plan, coding conventions).
To all contributors: Please, fill in your email addresses so we can contact each other personally. |
Fine by me, go ahead and set that up if you like. If it looks good and works efficiently I don't see why we can't use your style. Completely agree with a stable master branch. You can contact me on CoPRedux@googlemail.com, or probably better, if you have Steam, at http://steamcommunity.com/id/beacon |
In terms of compiling, I have not tried compiling yet, I just wanted to port over my changes from CS first which I know will work fine with COP. I completely agree. I think we need to agree on which COP repository to use first.
I also think we really should see if we can use VS2013 instead of 2008. Nitrocaster, I know you managed to do that with CS, and I have no idea how to do it at all. Would that be something you'd be interested in doing? You could pick what you want as the main branch then update it to 2013, then we can all work together on changes that follow the same style you use. My email is matthew.w.swartz@gmail.com I think what I'm going to do until we get all that done is port over all the changes I did for CS (such as the grass shadows by K.D.), into a separate branch and have only the files changed in there, which would allow for easy merging for features people want or don't want. |
What are the differences on the two repos you listed? |
For emails: I meant you profile settings For compiling: It is bad idea to commit code that you didn't try to compile. Things are not supposed to work this way, we need 'good' master branch. When I found CS sources, I spent about two days to make sure it can be compiled. For reference code: I suggest we use original sources for VS2008. Reason: no new bugs, only old well known ones. For using VS2013: There's no troubles to use VS2013 - just convert solution and projest files. There may be some problems with virtual directories in projects - that have to be fixed manually (awful routine, but it happens). |
Works for me. Just filled in my email. I may not have enough time today (have to work in a few hours), but I'll try to convert the project to VS2013 today then compile it. If it works I'll update things and post instructions the same way you did at your CS repo. Also, for some reason I had two upload the code in two parts using the Github utility as it would crash after around 7,500 files. Is there an alternative way of committing to Github? |
So, I'm going to dig into these sources, and once I get them all compiled I'll push them. |
@Swartz27, I understood from your previous post that you ask is I would get COP sources compiled under VS2013, so I'm ok with that. Are you going to do it by yourself? |
I was going to but if you're willing to do it I'll let you, then you can push it, and we can use what you've done as a base. I realized I have very little time today, I'll probably jump back on in roughly 7 hours and see if anyone has had any luck. I'll go over the proposed features list again and tidy it up after I've compared COP to CS source and then put them in order. |
Actually, I don't use Github utility for committing. I prefer git add + git commit + git push. If you're interested I use WinCmp (Compare it!) as diff/merge tool.
|
Good to be hearing ablout the structure and how things are going to unpack from here on. For my email, its "loner_dude@hotmail.com" for anything modding related. Looking forward to our cooperation, gents! Date: Thu, 18 Sep 2014 09:07:49 -0700 How do we go about creating a working executable or set of executables from the source? I'd be intrigued to try out the supposed new grass shadows, and then start looking at making changes of my own. — |
To @Swartz27 : What are 'cs' and 'patch-1' branches for? |
I don't remember creating either branch, though it looks like someone removed "patch-1". The CS branch could have been where I had forked your CS repo but it can't be because there's no CS files there. I'll remove it. |
Bangalore, we're waiting on Nitrocaster to update the source here to Visual Studio 2013. I recommend using that once it's out rather than messing with these other revisions. |
I suggest to the feature list to implement luajit 2.0.3, for the replace of luajit 1.1.4.: Luajit above version 2.0.0 compiles lua scripts much faster, it could remove microstutter, you can compare here the performance difference: |
100% yes also, nice to see you here Bangalore! |
I agree completely, I simply hadn't added the luajit version number in the proposed engine changes, but I had meant the version you speak of. |
To @Bangalore1010 : r8384 is kinda experimental version. |
@Bangalore1010 : Did you use the vs2008 version from the Github here or did you download it from the post on gameru? Just wondering because I encountered a bug trying to compile the source here, but I'm pretty sure it's the same version. Either way, downloaded it again from gameru. I think the reason I couldn't get it to compile was I don't have SP1 installed for VS2008 :P |
Do you have a link for the CS source code? Google translate is playing hell with me on the gameru.net site so I'm On 9/20/14, Bangalore1010 notifications@github.com wrote:
|
@tsf00181 : http://www.gameru.net/forum/index.php?s=297823ebaced19091f6c36b012189218&showtopic=55777&st=1700&p=1489128&#entry1489128 @Bangalore1010 : Did you encounter an error when compiling zlib that mentioned "_vsnprintf" being redefined? Just wondering, because I fixed it by going into zutil.h and commenting out lines 197 to 202. I'll post an update later as I have to go. |
I'd like to work on LuaJIT and LuaBind, when CoP sources will become compilable. |
I'd like to suggest to rename this repo to "xray-16", if you don't mind. |
I don't mind at all. In fact, nitrocaster, is it possible to transfer ownership of a repo? You have a good system with certain coding conventions, you're the top programmer here, etc. I think you should be in charge with us contributing. Also, unless you've gotten any farther on compiling it in VS2013, I think maybe we're good with leaving it at VS2008. I downloaded and compiled what Bangalore posted to be extra careful, beside the one modification I had to make which I mentioned, it worked fine (well, the R4 renderer isn't working at the moment. It's telling me my video card doesn't support it. So I need to figure out what's causing that which is probably me using a newer DirectX sdk than the one we're supposed to use). I'm actually going to delete the source code currently up and re-upload with the structure Bangalore is using once I can verify R4 works correctly. It's cleaner to post it that way. @STALKER2010 : Please do work on those, that would be great. With LUAJit are you going to be using the newest version, as that is what we would like to use.It means re-doing the vanilla LUA scripts too in order to work with the new version though. |
AFAIK, it's not necessary since I'm a contributor. Anyway, you can do it via support. For migrating to VS2013 - work in progress, just wait a little. For R4 renderer: do you have DX11-compatible GPU? If so, that is a problem in shader that I've already fixed (in my xray 1.5 repo). For this:
You uploaded the same code Bangalore use (vs2008.fixed). The only difference is that you missed SDK stuff. I'll take care of it, keep calm and don't delete anything :) |
Wow, it's not that I thought. Try to investigate. |
My guess is that the SDK isn't up to date for DX11. I'm going to try a later revision of the DirectX SDK and see if that solves it. Edit |
Looks like it doesn't want to be debugged: http://pastebin.com/Pr83gBWe Just noticed something else. Every time it crashes with that error it creates the precompiled shader for the r4 dumb.ps in your gamedata folder. WTF is that all about? |
That's why we should split it to multiple modules (maybe DLL + static libraries). |
Regarding
It's intended that |
Okay, so the dedicated server is not needed to run the game single player. Excellent. Also, thanks for the advice on how to start the game - much appreciated! On 5 May 2015 11:25:35 pm NZST, Pavel Kovalenko notifications@github.com wrote:
|
EDIT: setting edit2: no it didn't.... I am using visual studio 2013 community edition to compile, and I am compiling successfully, but the game won't start using start _bin_dbg/xrEngine.exe - start bin/xrEngine.exe works fine (I didn't compile that one though). Starting it from visual studio gives me:
and this log |
Do you really get stack overflow? Could you post stack trace?
|
Run from _bin_dbg: http://pastebin.com/UTXdVEEq |
and running from visual studio: http://pastebin.com/F6xSaLbm |
You should have got message box when the first failure happened. See |
and running from visual studio: |
Please use pastebin.com or another external storage for these huge logs. |
Sorry about that. I've set the game to be windowed. Upon starting the game, I get the little splash screen, then the window pops up - all black, then I get "X-ray 1.6 has stopped working" message: http://i.imgur.com/aLrTHiE.png I don't think that is the pop up you were expecting.... |
I solved it. I still had stalker complete mod installed. I was sure I removed it, bit obviously I was mistaken. Sorry for wasting your time, I feel like an idiot! On 6 May 2015 10:28:11 pm NZST, Pavel Kovalenko notifications@github.com wrote:
|
Plz help me I build sources from this repo and noticed that building xrGame project is a very very slow compared with build a clear sources of xrGame in Visual Studio 2008. Example, i comment two same lines in Actor.cpp in a both projects(from this repo and in clear project) As a result of building the project time was 4 minutes(VS2013) and 2 minutes(VS2008) How to fix it? |
Try to disable Multiprocessor compilation ( |
this not helped :( |
No way. Commenting two lines in any single cpp file means that only one cpp file should be recompiled. Given that you have precompiled headers enabled, such compilation should be quite fast. |
Removed some useless classes. XEM OpenXRay#157 SimpleDetector(.h/.cpp) -> item/ItemDetectorSimple(.h/.cpp) XEM OpenXRay#158 AdvancedDetector(.h/.cpp) -> item/ItemDetectorAdvanced(.h/.cpp) XEM OpenXRay#159 EliteDetector(.h/.cpp) -> item/ItemDetectorElite(.h/.cpp) XEM OpenXRay#162 PDA(.h/.cpp) -> item/ItemPDA(.h/.cpp) XEM OpenXRay#171 Torch(.h/.cpp) -> item/ItemTorch(.h/.cpp) XEM OpenXRay#172 CustomDetector(.h/.cpp) -> item/ItemDetectorCustom(.h/.cpp)
@nitrocaster @Armada651 close this one? |
@andrew-boyarshin If you think an issue can be closed, go ahead and close it. If it really still is an issue someone will reopen it. |
Precompile stdafx/pch headers for faster compilation and fix a mistake
- Removed glClipControl, shading language version can be downgraded - Removed useless pCFB buffer - Invert many screen quads - Invert matrices of viewport for lighting - Fixed flickering frames near light sources (shadowmaps are still incorrect) - Corrected TexelAdjust matrices - Invert scissor box - Removed flip from .tga screenshots - Some changes in shaders for ATI video cards #3 - Added key '-no_hom'
Fix format OpenXRay#3 Co-authored-by: Xottab_DUTY <Xottab-DUTY@users.noreply.github.com>
feat: Add lua file system library
How do we go about creating a working executable or set of executables from the source? I'd be intrigued to try out the supposed new grass shadows, and then start looking at making changes of my own.
The text was updated successfully, but these errors were encountered: