-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using reserve for loading smart covers #1323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good!
You can freely remove timers code from the code.
And fix the brackets. They always should be on a new lines.
@007exe, @BielBdeLuna, could you test the game with this PR? Can you notice performance boost when loading smart covers? :) |
@Xottab-DUTY, those are for the faction war of CS? |
@BielBdeLuna this only happens during level loading |
@BielBdeLuna, smart covers are used both in CS and COP, and not only for combat covers, but also for animations like sitting on a chair, etc. |
I can get this pr with this command isn't it?: |
what method can we use to test the changes? it's just loading the map?! |
@BielBdeLuna On release configuration, test branch with optimization and dev branch without this PR, it's enough just to load saves or start new game |
master gold is release isn't it? does it affect the test if I compile with |
Release with Master Gold on :)
Yes, it could. Different allocator probably would give different results. |
ok then I recompile both dev and your branch.... :) |
is there any easy way to make the level loading somewhat more verbose to help you out? |
Results: I added a message in the console when the game is in the main menu, and another when we are in-game, inbetween i started a new game: COP DEV BRANCH
CS DEV BRANCH
I hate CS intro! I can't stand it! COP RESERVE-SMART-COVERS BRANCH
it trullty felt quicker... butr this could be just expectations... CS RESERVE-SMART-COVERS BRANCH
those results doesn't contain d728b25 ad I don 't know how to implement it I hope it helps |
@BielBdeLuna, dev branch with commit "Added benchmark times" |
@GermanAizek how do I get the commit you posted? |
@Xottab-DUTY, @GermanAizek, results are on: #1323 (comment) |
d728b25
to
59b6bbb
Compare
…luabind_it_distance Signed-off-by: German Semenov <GermanAizek@yandex.ru>
59b6bbb
to
5382ace
Compare
My result benchmarks on Release
time.txt
time2.txt