Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace GLEW with GLAD #1684

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Replace GLEW with GLAD #1684

merged 1 commit into from
Jun 1, 2024

Conversation

Xottab-DUTY
Copy link
Member

@Xottab-DUTY Xottab-DUTY commented May 29, 2024

Benefits:

  • OpenGL 1.0 to 4.6
  • OpenGL ES 1.0 to 3.2
  • Handles function aliases
  • One header file
  • Carries no dependency (except for user provided function to load OpenGL extension. We use SDL_GL_GetProcAddress)
    • GLAD sources are integrated into our build system. This may be considered as disadvantage, but it gives us more portability.
    • Removes dependency from GLEW, which may be missing on some platforms (e.g. latest 32-bit Ubuntu versions)

The generated glad.h includes all available extensions, including GL_ARB_separate_shader_objects, but excluding GL_EXT_separate_shader_objects due to a conflict. I decided that it would be best to not include it at this moment (if ever).
Read more here: https://community.khronos.org/t/confused-gl-active-program-gl-current-program/65477.

@Xottab-DUTY
Copy link
Member Author

@sobkas, @AMS21, please look at it! Does it work under Linux?

@github-actions github-actions bot added Infrastructure External (3rd party) This issue is related to external component used by our project. labels May 29, 2024
@AMS21
Copy link
Contributor

AMS21 commented May 29, 2024

@sobkas, @AMS21, please look at it! Does it work under Linux?

Compiled with gcc 14.1.0 and seems to work fine on my machine :)

@Xottab-DUTY Xottab-DUTY merged commit 8623f5f into dev Jun 1, 2024
61 of 63 checks passed
@Xottab-DUTY Xottab-DUTY mentioned this pull request Jun 1, 2024
Xottab-DUTY added a commit that referenced this pull request Jun 1, 2024
It was removed in 20947ed just due to GLEW package is missing.
Now, thanks to GLAD (#1684), we can return it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External (3rd party) This issue is related to external component used by our project. Infrastructure OpenGL Portability Renderer
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants