Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for ImGui Hud Tuner #1688

Merged
merged 4 commits into from
Jun 7, 2024
Merged

Conversation

yohjimane
Copy link
Contributor

@yohjimane yohjimane commented Jun 3, 2024

Improved responsiveness by containing radio buttons and buttons within Tables, which resize dynamically based on current window width

Add some useful tooltips which display information when hovering over bone radio buttons and animation buttons, in case any of them clip due to text length.

@yohjimane yohjimane changed the title Improve responsiveness for ImGui Hud Tuner Imrpovements for ImGui Hud Tuner Jun 3, 2024
@yohjimane yohjimane force-pushed the yohji/feat/hud-tuner-improvements branch from fa01995 to 7578772 Compare June 3, 2024 08:31
@yohjimane yohjimane changed the title Imrpovements for ImGui Hud Tuner Improvements for ImGui Hud Tuner Jun 3, 2024
@Xottab-DUTY Xottab-DUTY added Enhancement Renderer Modmaker Experience Modmaker experience with OpenXRay and removed Renderer labels Jun 4, 2024
@Xottab-DUTY
Copy link
Member

So, is it ready for merge?

Copy link
Member

@Xottab-DUTY Xottab-DUTY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code style

src/xrGame/player_hud_tune.cpp Outdated Show resolved Hide resolved
src/xrGame/player_hud_tune.cpp Outdated Show resolved Hide resolved
src/xrGame/player_hud_tune.cpp Outdated Show resolved Hide resolved
src/xrGame/player_hud_tune.cpp Outdated Show resolved Hide resolved
@yohjimane
Copy link
Contributor Author

@Xottab-DUTY code changes look good to me, ready for merge!

@Xottab-DUTY Xottab-DUTY merged commit 3ab767c into dev Jun 7, 2024
28 of 63 checks passed
@Xottab-DUTY Xottab-DUTY deleted the yohji/feat/hud-tuner-improvements branch June 7, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Modmaker Experience Modmaker experience with OpenXRay
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants