Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paddr: add comments to mmap in init_mem #162

Merged
merged 1 commit into from
Sep 6, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/memory/paddr.c
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@ void init_mem() {
#ifdef CONFIG_MULTICORE_DIFF
panic("Pmem must not use mmap during multi-core difftest");
#endif
// Note: we are using MAP_FIXED here, in the SHARED mode, even if
// init_mem may be called multiple times, the memory space will be
// allocated only once at the first time called.
// See https://man7.org/linux/man-pages/man2/mmap.2.html for details.
void *ret = mmap((void *)pmem, MEMORY_SIZE, PROT_READ | PROT_WRITE,
MAP_ANONYMOUS | MAP_PRIVATE | MAP_FIXED, -1, 0);
if (ret != pmem) {
Expand Down
Loading