Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(vaddr): cross page write check should use original vaddr #587

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Fix(vaddr): cross page write check should use original vaddr #587

merged 1 commit into from
Oct 16, 2024

Commits on Oct 15, 2024

  1. Fix(vaddr): cross page write check should use original vaddr 

    In our design, requests that cross page are split into two non-cross page requests in `vaddr_write_cross_page`, which are handled separately in `vaddr_trans_and_check_exception`.

However, in previous design, `vaddr_trans_and_check_exception` would pass a page-aligned vaddr (`vaddr & ~PAGE_MASK`) into `isa_mmu_translate`, which would result in the lower 12 bits of exception address (page offset) written to *tval going to all zeros. This will result in an error against rtl if an exception occurs. This commit fixes it.
    @good-circle
    good-circle committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    91f87c6 View commit details
    Browse the repository at this point in the history