Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mmu): incorrect tval update when delegating to VS #590

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

cebarobot
Copy link
Member

When delegating PF to VS, it should update vstval; when delegating PF to S, it should update stval; otherwise, it should update mtval. However, the previous NEMU sometimes updates vstval when delegating PF to VS. It's really strange that we did not find this bug brefore.

This patch also adds INTR_TVAL2_REG / INTR_TINST_REG macro and uses them to refractor some other codes.

When delegating PF to VS, it should update vstval; when delegating PF to S, it should update stval; otherwise, it should update mtval. However, the previous NEMU sometimes updates vstval when delegating PF to VS. It's really strange that we did not find this bug brefore.

This patch also adds INTR_TVAL2_REG / INTR_TINST_REG macro and uses them to refractor some other codes.
@cebarobot cebarobot merged commit 4fd20c2 into master Oct 16, 2024
7 checks passed
@cebarobot cebarobot deleted the fix-tval branch October 16, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants