Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump chisel and scala #3028

Merged
merged 4 commits into from
Jun 5, 2024
Merged

deps: bump chisel and scala #3028

merged 4 commits into from
Jun 5, 2024

Conversation

eastonman
Copy link
Member

Chisel 6.4.0 has released https://github.com/chipsalliance/chisel/releases/tag/v6.4.0

Also bump scala because I encounter a scala compiler bug in JDK 21.
scala/bug#12783
This is fixed in 2.13.11+

@poemonsense
Copy link
Member

Is this Scala version still compatible with Chisel 3.6.0?

@eastonman
Copy link
Member Author

No, unfortunately, chisel3-plugin is released up to scala 2.13.10

@eastonman
Copy link
Member Author

I will remove the Scala version bump in this PR.
I believe JDK 17 is still considered "modern" now?

@eastonman
Copy link
Member Author

Unfortunately, for some reason, scala 2.13.10 cannot compile under JDK 17 either.
Do we now have to deal with two Scala versions?

@Tang-Haojin
Copy link
Member

Tang-Haojin commented Jun 1, 2024 via email

@poemonsense
Copy link
Member

Unfortunately, for some reason, scala 2.13.10 cannot compile under JDK 17 either. Do we now have to deal with two Scala versions?

It works on my environment with JDK 17, Scala 2.13.10, and Chisel 3.6.0

@eastonman
Copy link
Member Author

OK, I notice there is an issue with my JDK. JDK 17 seems ok now.

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 6514e07

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
6514e07 1.821 0.448 2.054 1.173 2.950 2.500 2.291 0.923 1.376 1.265 3.448 2.667 2.398 2.940

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
31fae68 1.815 0.448 2.060 1.182 2.953 2.504 2.291 0.930 1.403 1.319 3.426 2.660 2.397 2.940
071c63e 1.815 0.448 2.060 1.182 2.953 2.504 2.291 0.930 1.403 1.319 3.426 2.660 2.397 2.940
6b742a1 1.821 0.448 2.054 1.173 2.950 2.500 2.291 0.923 1.376 1.265 3.448 2.667 2.398 2.940
dc30dd9 1.821 0.448 2.054 1.173 2.950 2.500 2.291 0.923 1.376 1.265 3.448 2.667 2.398 2.940
cd467f7 1.821 0.448 2.054 1.173 2.950 2.500 2.291 0.923 1.376 1.265 3.448 2.667 2.398 2.940
75b44a5 1.821 0.448 2.054 1.173 2.950 2.500 2.291 0.923 1.376 1.265 3.448 2.667 2.398 2.940
321866f 1.821 0.448 2.054 1.173 2.950 2.500 2.291 0.924 1.376 1.265 3.448 2.667 2.398 2.940
082b30d 1.821 0.448 2.054 1.173 2.950 2.500 2.291 0.923 1.376 1.265 3.448 2.667 2.398 2.940
0e28018 1.823 0.448 2.054 1.172 2.950 2.500 2.292 0.923 1.376 1.265 3.449 2.656 2.398 2.943
df7130a 1.823 0.448 2.054 1.172 2.950 2.500 2.292 0.923 1.376 1.265 3.449 2.656 2.398 2.943

@Tang-Haojin Tang-Haojin merged commit 4c46d75 into master Jun 5, 2024
4 checks passed
@Tang-Haojin Tang-Haojin deleted the deps-bump-chisel branch June 5, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants