Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

[question] - -e Docker Variables available #680

Closed
jaburges opened this issue Aug 21, 2020 · 8 comments · Fixed by #725
Closed

[question] - -e Docker Variables available #680

jaburges opened this issue Aug 21, 2020 · 8 comments · Fixed by #725
Assignees
Labels
question Further information is requested

Comments

@jaburges
Copy link

Unraid uses a pretty cool UI (Community Applications - which are basically docker containers deployed via the UI).

It allows the specification of the port, the volumes etc, but also some environment variables.

Do you surface up -e Network_Key for example? It would be useful to specify that (and maybe any other useful variables) for a user to carry out a one click install.

Most valuable reason for this is the automatic updating of the docker containers.
I've kicked off a Community App request here

@jaburges jaburges added the question Further information is requested label Aug 21, 2020
@robertsLando
Copy link
Member

Hi @jaburges ! I could make the support for that but why supply network key from env var instead of provide it from the UI? For security purposes?

@jaburges
Copy link
Author

in UnRaid UI you can add these items so the Z2M starts with the right key

@robertsLando
Copy link
Member

@jaburges I understand this but you can also provide it from the UI, this is why I'm asking the pro/cons by add it using env vars

@jaburges
Copy link
Author

jaburges commented Sep 5, 2020

I think the preferred way for Unraid users is to specify everything possible in the UI with -e / ENV variables.

If it's a lot of work, I would not bother. If it's easy it will open your solution up to more Unraid users.

@robertsLando
Copy link
Member

Configuration are a lot, create an env var for each one would be a lot of work and I sincerly still don't understand the advantage of this. If you simply run z2m with Unraid then you go to localhost:8091 and configure it from the UI why would you need to specify things from env?

I would use env vars for the port of the server (there is already an env var for that) and other server specific configuration. Also adding the controller key would be easy but it can be configured from the ui so I'm not sure if it's useful

@jaburges
Copy link
Author

jaburges commented Sep 8, 2020

in terms of security the qt-openzwave docker has the option to add the network_key as an ENV.

i get your point, and you maybe able to just set up an Unraid template (for updating without the ENV variables)
i'll close this

@jaburges jaburges closed this as completed Sep 8, 2020
@robertsLando
Copy link
Member

Open an issue for that, it's a very easy feature to add I will make it once I come back from holidays :)

robertsLando added a commit that referenced this issue Sep 14, 2020
@robertsLando
Copy link
Member

@jaburges just submitted a feat for this

@robertsLando robertsLando linked a pull request Sep 15, 2020 that will close this issue
robertsLando added a commit that referenced this issue Sep 15, 2020
Co-authored-by: Chris Nesbitt-Smith <chris@cns.me.uk>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants