feat: parse value functions #739 #741
Conversation
| debug('Error eval function of value ', valueId.value_id, error.message) | ||
| } | ||
|
|
||
| return result |
There was a problem hiding this comment.
is returning null on failure better than returning the original value?
can you return a promise? does it work?
There was a problem hiding this comment.
It works in this way (I have tested this with a real device). I would not return a promise as the conversion function should be fast.
I could return the original value when it fails but I think this makes the code more readable, I mean If I return the original value, by reading the code seems that the function has return that value. What do you think it's better?
There was a problem hiding this comment.
promises can be fast, the question is to whether it has to be sync or can it be async.
either is probably fine, but i'd make that clear in the gui that it must be a syncronis response.
theres technically no reason not to do async/promises, but i'm sure it could introduce all sorts of peculiar race conditions
| debug('Error eval function of value ', valueId.value_id, error.message) | ||
| } | ||
|
|
||
| return result |
There was a problem hiding this comment.
promises can be fast, the question is to whether it has to be sync or can it be async.
either is probably fine, but i'd make that clear in the gui that it must be a syncronis response.
theres technically no reason not to do async/promises, but i'm sure it could introduce all sorts of peculiar race conditions
This will allow users to specify a custom parse/recieve js function in gateway values table :)