tidy up the docker build #769
Conversation
chrisns
force-pushed
the
tidy_dockerbuild
branch
from
03e7303 to
a6f93ad
Compare
| TAGS="${TAGS}${DOCKER_REPO}:$(echo ${GITHUB_REF} | sed "s/refs\/tags\/v//")\n" | ||
| fi | ||
|
|
||
| TAGS="${TAGS}${DOCKER_REPO}:sha-${GITHUB_SHA}" |
There was a problem hiding this comment.
Yeah, sorry forgot to call out
There was a problem hiding this comment.
No, more for allowing someone to use something ahead of a release without opening themselves to a breaking change coming in next time they pull
There was a problem hiding this comment.
And what about the 'just build on pr' part? It will push also pull requests with the format robertslando/zwave2mqtt:sha-<sha>?
There was a problem hiding this comment.
Only prs on this repo, prs from forks don't get the secret to push
There was a problem hiding this comment.
Oh missed the if in the login part
There was a problem hiding this comment.
its more that forks don't get access to the secrets, otherwise anyone could just get your dockerhub creds
|
Seen build fail. Will fix shortly |
|
Ok let me know, sincerly I have checked the code and I don't understand why the tag isn't appended correctly in the string, maybe the |
|
its loosing that its multiline var |
|
related to actions/toolkit#403 i think |
|
😕 |
No description provided.