-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation problem with Node 0.12.4 #2
Comments
Sorry, node 0.12 not supported yet, it gave me serious headache. |
Better get my #ifdef-fu ready for action: There are quite a few API-breaking changes in Node 0.12 - and this is not going to be easy. |
Could also try to use NaN - (think it stands for Node (is) a Nightmare) |
Hi Wojciech, |
Hi Elias, make: Entering directory
|
Can you please give it another shot? I've replaced all |
Elias, Now, this is what I see: /usr/local/include/openzwave/aes/aes.h:75: warning: ignoring #pragma warning
|
yup, the same applies to |
OK, I've tried using OZW's getValueAsString to get the float values back as strings. It should compile now. Do you have any temperature sensors (or any zwave device that reports floating point values?) |
Yes, i do but i Will be ale to test it tomorrow afternoon EST...
|
This is what we have now: ../src/openzwave-driver.cc: In function ‘void OZW::Connect(const v8::FunctionCallbackInfov8::Value&)’:
|
Oh no, its the callback API.... it has changed too (has ANYTHING remained the same between 0.10 and 0.12???) |
uh-oh, all calls to MakeCallback have to be changed! |
ok I've managed to set up a 0.12.4 working environment, and get all necessary changes to get the full NaN goodness baked in and the source now successfully compiles against both 0.12.4 AND 0.10.25. Could you please give it a shot? - but have a fire extinguisher at close range :) |
No need for fire extinguisher ;); compiled just fine, thank You I will do some testing over the weekend
|
I just tried adding it to node-red, so I installed node-red-control-openzwave with dependency disabled, however on startup I get:
|
It was a silly namespace issue. Module now boots up correctly: $ node test.js Although I havent even addressed the missing prototype copied methods issue, you should be able to invoke the addon directly (eg "zwave.addon.") Can you git pull and retry? |
I loads properly Thank You
|
...but its not working. MakeCallback() signature has changed and its clearly passing something other than a function..: |
oh, did not get that far, so I will wait for u now
|
I'm afraid I'll have to rewrite everything so as to use NanAsyncWorker. |
Hey, Wojciech good news!. |
Eccellent news
|
Here we go: All seems to be fine, I just need to test with actual devices… Welcome to Node-RED14 Jun 20:13:57 - [info] Node-RED version: v0.10.6
|
ok then I think we can consider this issue closed. |
Can not install it on CentOS 7 with Node 0.12.4:
make: Entering directory `/usr/local/lib/node_modules/openzwave-shared/build'
CXX(target) Release/obj.target/openzwave_shared/src/openzwave.o
In file included from /usr/local/include/openzwave/aes/aescpp.h:26:0,
from /usr/local/include/openzwave/Driver.h:41,
from /usr/local/include/openzwave/Manager.h:39,
from ../src/openzwave.hpp:29,
from ../src/openzwave.cc:18:
/usr/local/include/openzwave/aes/aes.h:75:0: warning: ignoring #pragma warning [-Wunknown-pragmas]
#pragma warning( disable : 4324 )
^
/usr/local/include/openzwave/aes/aes.h:93:0: warning: ignoring #pragma warning [-Wunknown-pragmas]
#pragma warning( default : 4324 )
^
In file included from ../src/openzwave.cc:18:0:
../src/openzwave.hpp:96:26: error: expected class-name before ‘{’ token
struct OZW : ObjectWrap {
^
../src/openzwave.hpp:97:38: error: ‘Arguments’ does not name a type
static Handlev8::Value New(const Arguments& args);
^
../src/openzwave.hpp:97:49: error: ISO C++ forbids declaration of ‘args’ with no type [-fpermissive]
static Handlev8::Value New(const Arguments& args);
^
../src/openzwave.hpp:99:49: error: ‘Arguments’ does not name a type
static Handlev8::Value SetConfigParam(const Arguments& args);
^
../src/openzwave.hpp:99:60: error: ISO C++ forbids declaration of ‘args’ with no type [-fpermissive]
static Handlev8::Value SetConfigParam(const Arguments& args);
.......
The text was updated successfully, but these errors were encountered: