Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code reference update to version bump script #478

Closed
andrew-fleming opened this issue Sep 21, 2022 · 0 comments · Fixed by #472
Closed

Add code reference update to version bump script #478

andrew-fleming opened this issue Sep 21, 2022 · 0 comments · Fixed by #472

Comments

@andrew-fleming
Copy link
Collaborator

andrew-fleming commented Sep 21, 2022 •
edited
Loading

It might be easier to use the version reference instead of the hash for automatic updates. For example, I propose using this:

https://github.com/OpenZeppelin/cairo-contracts/blob/release-v0.4.0b/src/openzeppelin/account/presets/Account.cairo

as opposed to this:

https://github.com/OpenZeppelin/cairo-contracts/blob/abc123456789/src/openzeppelin/account/presets/Account.cairo
@martriay martriay moved this to 📋 Backlog in Cairo team Sep 21, 2022
@andrew-fleming andrew-fleming mentioned this issue Sep 22, 2022
Merged
@martriay martriay added this to the next milestone Sep 24, 2022
@martriay martriay modified the milestones: next, current Oct 3, 2022
Repository owner moved this from 📋 Backlog to ✅ Resolved in Cairo team Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Cairo team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update documentation to Cairo v0.10 andrew-fleming/cairo-contracts
2 participants
@martriay @andrew-fleming