Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation to Cairo v0.10 #472

Merged
merged 41 commits into from
Oct 3, 2022
Merged

Update documentation to Cairo v0.10 #472

merged 41 commits into from
Oct 3, 2022

Conversation

andrew-fleming
Copy link
Collaborator

@andrew-fleming andrew-fleming commented Sep 19, 2022 •
edited
Loading

Resolves #451 and resolves #478.

This also fixes #456.

@andrew-fleming
update interface
d9edd7f
@andrew-fleming
update signature section
4e3ab4c
@andrew-fleming
start lib api
9b1ad16
@andrew-fleming
camelCase constructor param
3d982aa
@andrew-fleming
update syntax on snippet and interfaces
5be1e12
@andrew-fleming
update syntax on snippets and interfaces
f1e4b7e
@andrew-fleming
update syntax, change api to camelCase, update account entrypoints
4189556
@andrew-fleming
update syntax on snippets and interfaces
57fafd3
@andrew-fleming
fix ierc721receiver api
d0a339e
@andrew-fleming
update syntax in snippet
62f4c70
@andrew-fleming
update syntax in snippet
2df75f6
@andrew-fleming
update syntax in snippets and interface
9bbdb9e
@andrew-fleming
update syntax in snippets and interface
72cc542
@andrew-fleming
update syntax in snippets
695afbd
@andrew-fleming
fix implicit args
26481ad
@andrew-fleming
update syntax in snippet
947f7ca
@andrew-fleming
add semicolons
3e54015
@andrew-fleming
add space before curly brackets
226dcad
@andrew-fleming
add space before curly brackets
8171ab7
@andrew-fleming
add version to url
9a32376
@andrew-fleming
fix extending the account section
6ea2f7e
@andrew-fleming
update links
02bf224
@andrew-fleming andrew-fleming marked this pull request as ready for review September 22, 2022 20:07
ericnordelo
ericnordelo requested changes Sep 29, 2022
View reviewed changes
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review Andrew. I left some comments and format suggestions.

README.md Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/access.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/access.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/accounts.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/accounts.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/extensibility.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/extensibility.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/index.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/proxies.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/proxies.adoc Outdated Show resolved Hide resolved
@andrew-fleming andrew-fleming marked this pull request as draft September 29, 2022 22:13
@andrew-fleming andrew-fleming marked this pull request as ready for review September 30, 2022 19:48
ericnordelo
ericnordelo approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@andrew-fleming andrew-fleming merged commit 4c151ee into OpenZeppelin:main Oct 3, 2022
@andrew-fleming andrew-fleming deleted the docs-0.4.0 branch October 3, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericnordelo ericnordelo ericnordelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@andrew-fleming @ericnordelo