Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Checkpoint public and fix interface #1021

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Make Checkpoint public and fix interface #1021

merged 3 commits into from
Jun 26, 2024

Conversation

ericnordelo
Copy link
Member

@ericnordelo ericnordelo commented Jun 25, 2024 •
edited
Loading

Fixes #1020

@ericnordelo ericnordelo mentioned this pull request Jun 25, 2024
Closed
andrew-fleming
andrew-fleming reviewed Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, sir. We still need to make checkpoint and storage_array public in utils/structs.cairo

andrew-fleming
andrew-fleming approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericnordelo ericnordelo merged commit 8509b60 into OpenZeppelin:main Jun 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-fleming andrew-fleming andrew-fleming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERC20Votes Interface implementation
2 participants
@ericnordelo @andrew-fleming