Add hooks section #1090
Add hooks section #1090
Conversation
There was a problem hiding this comment.
Looking good @andrew-fleming. Left a suggestion to simplify the code. Not sure if we should update the Medium post accordingly.
| } | ||
|
|
||
| // Occurs after token transfers | ||
| fn after_update( |
There was a problem hiding this comment.
We now can have default function implementations in traits, so we can simplify this pattern by setting default empty functions in the Hooks trait, removing the need for an empty function in the custom impl. I think we can use this PR for that as well.
There was a problem hiding this comment.
Note that the default empty impl is still helpful, but it should be refactored to an empty (without functions) impl definition, since the empty functions should come from the Hook trait definition itself.
There was a problem hiding this comment.
I think this example shouldn't include the empty function, but maybe a note stating that the default for the other hook functions is an empty implementation.
Co-authored-by: immrsd <103599616+immrsd@users.noreply.github.com>
@ericnordelo It's probably enough to just include a note in the post ("As of v0.15.1..."). The default fns doesn't break the old flow. I'll wait until near the next release though |
Fixes #979.
PR Checklist