Add declare script for presets #1118
Conversation
packages/presets/scripts/src/declare_presets/declare_presets.cairo
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1118 +/- ##
=======================================
Coverage 88.87% 88.87%
=======================================
Files 57 57
Lines 1375 1375
=======================================
Hits 1222 1222
Misses 153 153 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Nice start @andrew-fleming. I wonder why is this located inside the presets package being a housekeeping improving script. I would move it out of it, maybe into a sncast_scripts directory on the root of the project, that won't be part of the released workspace.
Co-authored-by: immrsd <103599616+immrsd@users.noreply.github.com>
| --account path/to/account.json \ | ||
| --keystore path/to/key.json \ | ||
| script run declare_presets \ | ||
| --url http://127.0.0.1:5050 |
There was a problem hiding this comment.
| --account path/to/account.json \ | |
| --keystore path/to/key.json \ | |
| script run declare_presets \ | |
| --url http://127.0.0.1:5050 | |
| script run declare_presets \ | |
| --account path/to/account.json \ | |
| --keystore path/to/key.json \ | |
| --url http://127.0.0.1:5050 |
There was a problem hiding this comment.
Having options after the command feels more natural.
There was a problem hiding this comment.
I agree, but sncast only accepts the account flag before the command
sncast_scripts/Scarb.toml
Outdated
| @@ -0,0 +1,25 @@ | |||
| [package] | |||
| name = "sncast_scripts" | |||
| version = "0.17.0" | |||
There was a problem hiding this comment.
| version = "0.17.0" | |
| version = "0.1.0" |
Does this need to be pegged to the latest release from the library?
There was a problem hiding this comment.
Mmm no, probably not. Good call
| @@ -0,0 +1 @@ | |||
| mod declare_presets; | |||
There was a problem hiding this comment.
Why can't we have the script code in here? Do we need the extra directory?
There was a problem hiding this comment.
Nope, updated!
This PR proposes to add a sncast script that declares all the preset contracts. This script aims to improve the releasing process.
PR Checklist