Bump starknet foundry to 0.30.0 #1137
Conversation
There was a problem hiding this comment.
Looking great @ggonzalez94! I Left just a small suggestion, but besides that, it looks ready to go.
| @@ -1,11 +1,16 @@ | |||
| use crate::panic_data_to_byte_array; | |||
| use snforge_std::{ContractClass, ContractClassTrait}; | |||
| use snforge_std::{ContractClass, ContractClassTrait, DeclareResult}; | |||
| use starknet::ContractAddress; | |||
|
|
|||
| /// Declares a contract with a `snforge` `declare` call and unwraps the result. | |||
| pub fn declare_class(contract_name: ByteArray) -> ContractClass { | |||
There was a problem hiding this comment.
Since this change affects the declare_and_deploy and declare_and_deploy_at functions behavior, I think it is worth adding a note to those stating that the function will skip declaration if the contract is already declared. A note on this function could be helpful as well.
There was a problem hiding this comment.
Good catch! I just updated the inline docs and the antora docs. Let me know what you think.
|
I forgot to mention the CHANGELOG. We have to add the corresponding entries:
|
Co-authored-by: Eric Nordelo <eric.nordelo39@gmail.com>
|
@ericnordelo @andrew-fleming I think this is now ready for a final review and hopefully ready to merge 🤞 |
Fixes #1135 and unblocks #1129
snforge_stdto 0.30.0assert_macrosdependency, which is required afterv0.28.0DeclareResultenum0x(e.g. instead of0x06dd34965d008db405187f4ea6170934a051f8ebb4b72c8aba99cb217a281ad4starknet foundry returns0x6dd34965d008db405187f4ea6170934a051f8ebb4b72c8aba99cb217a281ad4), so I created a new function in the common test helpersinto_base_16_string_no_padding, which is the same as its padding counterpart but matches the starknet foundry output. We could remove the other one, but it is part of the public api - so I decided to keep it, but don't have a strong opinion about it.PR Checklist